fix(devkit): combineAsyncIterable should not be blocking when error occurs #21393 #23400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7c7e109. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
ndcunningham
approved these changes
May 15, 2024
Coly010
force-pushed
the
module-federation/fix-dev-remotes
branch
2 times, most recently
from
8d21565
to
fa383b2
Compare
Coly010
changed the title
jaysoo
reviewed
May 16, 2024
packages/devkit/src/utils/async-iterable/combine-async-iterables.spec.ts
Outdated
Show resolved
Hide resolved
Coly010
force-pushed
the
module-federation/fix-dev-remotes
branch
from
fa383b2
to
7c7e109
Compare
xiongemi
approved these changes
May 17, 2024
jaysoo
approved these changes
May 21, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
May 21, 2024
…ccurs #21393 (#23400) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> `combineAsyncIterators` has a `finally` block which is blocking execution waiting for all iterators to be `done` so it can call the `return` function as cleanup. This leads to prolonged execution when unnecessary, such as when an error has occurred. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> `finally` block should be non-blocking allowing errors to be immediately surfaced and execution to stop. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #21393 (cherry picked from commit 4442945)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
combineAsyncIteratorshas afinallyblock which is blocking execution waiting for all iterators to bedoneso it can call thereturnfunction as cleanup.This leads to prolonged execution when unnecessary, such as when an error has occurred.
Expected Behavior
finallyblock should be non-blocking allowing errors to be immediately surfaced and execution to stop.Related Issue(s)
Fixes #21393