-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(core): add changelog renderOptions to nx-schema.json #23323
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b9de2ca. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Based on `DefaultChangelogRenderOptions` missing coma
@pkuczynski The trouble with this is that the changelog renderer is swappable by design. There is no way in JSON schema (that I am aware of) to customize these values dynamically based on the value of the renderer property. If using a custom renderer there is no requirement for the options to be the same as these (again by design), so the schema would give incorrect feedback, which I think is worse than none given there is no way to override it. For that reason I am going to close this one for now unless we can somehow can up with a reliable dynamic solution. Many thanks! |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Schema does not have the documentation
Expected Behavior
Schema should list options from
DefaultChangelogRenderOptions