Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module Federation Dev server does not error out if a dev remote fails to start. #21393

Closed
1 of 4 tasks
statop opened this issue Jan 29, 2024 · 0 comments · Fixed by #23400
Closed
1 of 4 tasks

Module Federation Dev server does not error out if a dev remote fails to start. #21393

statop opened this issue Jan 29, 2024 · 0 comments · Fixed by #23400
Assignees
@Coly010
Labels
scope: module federation Issues related to module federation support type: bug

Comments

@statop
Copy link

statop commented Jan 29, 2024

Current Behavior

Module Federation Dev server does not error out if a dev remote fails to start.

Expected Behavior

Module Federation Dev server errors out if a dev remote fails to start.

GitHub Repo

No response

Steps to Reproduce

  1. Make a dev remote fail to start by making it have a bad config or something
  2. The federation dev server will sit and wait for it to start.

Nx Report

>  NX   Report complete - copy this into the issue template

   Node   : 18.17.1
   OS     : darwin-arm64
   pnpm   : 8.14.3

   nx                 : 17.2.8
   @nx/js             : 17.2.8
   @nx/jest           : 17.2.8
   @nx/eslint         : 17.2.8
   @nx/workspace      : 17.2.8
   @nx/angular        : 17.2.8
   @nx/devkit         : 17.2.8
   @nx/eslint-plugin  : 17.2.8
   @nx/node           : 17.2.8
   @nx/plugin         : 17.2.8
   @nx/react          : 17.2.8
   @nx/rollup         : 17.2.8
   @nx/storybook      : 17.2.8
   @nx/vite           : 17.2.8
   @nx/web            : 17.2.8
   @nx/webpack        : 17.2.8
   typescript         : 5.2.2
   ---------------------------------------
   Community plugins:
   @openadp/tools-plugin : 24.5.0
   @storybook/angular    : 7.6.10
   ---------------------------------------
   Local workspace plugins:
   	 @openadp/tools-plugin

Failure Logs

No response

Package Manager Version

pnpm 8.14.3

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

No response
@AgentEnder AgentEnder added the scope: module federation Issues related to module federation support label Feb 2, 2024
Coly010 added a commit that referenced this issue May 15, 2024
@Coly010
fix(module-federation): devRemotes error should error serve immediately
37b0f04 
#21393
@Coly010 Coly010 mentioned this issue May 15, 2024
Merged
Coly010 added a commit that referenced this issue May 15, 2024
@Coly010
fix(module-federation): devRemotes error should error serve immediately
8d21565 
#21393
jaysoo pushed a commit that referenced this issue May 21, 2024
@Coly010
fix(devkit): combineAsyncIterable should not be blocking when error o…
4442945 
…ccurs #21393 (#23400)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->
`combineAsyncIterators` has a `finally` block which is blocking
execution waiting for all iterators to be `done` so it can call the
`return` function as cleanup.
This leads to prolonged execution when unnecessary, such as when an
error has occurred.


## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
`finally` block should be non-blocking allowing errors to be immediately
surfaced and execution to stop.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #21393
FrozenPandaz pushed a commit that referenced this issue May 21, 2024
@Coly010 @FrozenPandaz
fix(devkit): combineAsyncIterable should not be blocking when error o…
756157c 
…ccurs #21393 (#23400)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->
`combineAsyncIterators` has a `finally` block which is blocking
execution waiting for all iterators to be `done` so it can call the
`return` function as cleanup.
This leads to prolonged execution when unnecessary, such as when an
error has occurred.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
`finally` block should be non-blocking allowing errors to be immediately
surfaced and execution to stop.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #21393

(cherry picked from commit 4442945)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Coly010 Coly010

Labels
scope: module federation Issues related to module federation support type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(devkit): combineAsyncIterable should not be blocking when error occurs #21393 nrwl/nx
3 participants
@statop @AgentEnder @Coly010