-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(echo): Mvp test suite #5583
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-packages-to-the-monorepo # Conflicts: # pnpm-lock.yaml
…-packages-to-the-monorepo
…-packages-to-the-monorepo # Conflicts: # pnpm-lock.yaml
…o-the-monorepo' into NV-3670/relocate-echo-packages-to-the-monorepo
…o-the-monorepo' into nv-3653-add-ci-for-testing-sdk-cli # Conflicts: # packages/cli-next/src/start-studio.ts
…-3653-add-ci-for-testing-sdk-cli
…-3653-add-ci-for-testing-sdk-cli
❌ Deploy Preview for dev-web-novu failed. Why did it fail? →
|
✅ Deploy Preview for novu-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
djabarovgeorge
requested review from
a team,
SokratisVidros and
ainouzgali
and removed request for
a team
May 27, 2024 10:22
djabarovgeorge
changed the title
Nv 3672 add sdk mvp test suite
feat: add sdk mvp test suite. nv-3672
May 27, 2024
djabarovgeorge
changed the title
feat: add sdk mvp test suite. nv-3672
feat(echo): add sdk mvp test suite. nv-3672
May 27, 2024
rifont
changed the title
feat(echo): add sdk mvp test suite. nv-3672
test(echo): Sdk mvp test suite
May 28, 2024
rifont
changed the title
test(echo): Mvp test suite
test(echo): Mvp test suite [NV-3672]
May 28, 2024
rifont
changed the title
test(echo): Mvp test suite [NV-3672]
test(echo): Mvp test suite
May 28, 2024
rifont
approved these changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
# Conflicts: # packages/echo/src/index.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer