Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New zoom mode to resize the browser #1849

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

XiaoXianNv-boot
Copy link

I've added a new zoom mode that allows the browser to automatically adapt to the window .
Just need to use window.open('vnc. html/?token=token&autoconnect=1&resize=browser','_blank','toolbar=no,location=no,status=no,menubar=no,resizable=yes,width=800,height=420'); Open a window
Works fine on EDGE

@CendioOssman
Copy link
Member

Thank you for your contribution!

I'm thinking this might be a bit too niche, though, since it only works under very specific circumstances. Could you describe your setup a bit more, and where this feature fits in?

@XiaoXianNv-boot
Copy link
Author

Used to open the QEMU/KVM console in a new browser window, yes, QEMU/KVM will constantly change the resolution when it is launched

@XiaoXianNv-boot
Copy link
Author

I'm connected to the VNC port of KVM/QEMU via websockify

@XiaoXianNv-boot
Copy link
Author

Copy link
Member

@CendioOssman CendioOssman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. That sounds reasonble. I'm cautious about adding niche stuff to the general UI, though.

In TigerVNC, we have a similar behaviour but without a setting. Perhaps that could be used here as well?

The principle there is that it will resize the local window if the sizes match before the resize, but not if they are different. I.e.

  1. VNC session is 1024x768, local window is 1024x768. VNC session resizes to 1920x1080, and the local window tries to resize to the same 1920x1080.
  2. VNC session is 1024x768, but local window is 800x600. VNC session resizes to 1920x1080, but the local window stays at 800x600.

@samhed samhed added the feature label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants