New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assert: --assert-full-diff #52921
base: main
Are you sure you want to change the base?
assert: --assert-full-diff #52921
Conversation
i'd rather we add an options object to |
I'm worried that users may misunderstand the options object for an object to be asserted |
The commit message does not adhere to the guidelines, the tests are not passing: I'm converting this PR to draft. I think you can that reviewing PRs takes time, and as it is currently it doesn't seem like reviewing this PR would be a good use of my time. Sorry if my comment sounds dismissive, I know you spent time making this PR, and I would prefer show more respect of that time you spend, but honestly I don't feel that you sending this PR as is is very respectful of the reviewers' time either. |
No problem! I'll fix the PR and verify everything before I resubmit
I'm sorry, I'll fix the PR, I didn't realize it was failing the tests (sorry!). |
ac2e677
to
2a0ae9b
Compare
(forgot to un-draft this)
|
Fixes #51902
This PR adds a
--assert-full-diff
option to have AssertionErrors print the full diff, rather than a truncated version.