New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: remove ArrayBufferAllocator::Reallocate override #52910
base: main
Are you sure you want to change the base?
Conversation
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/9016827306 |
@benjamingr I see that I got the commit message capitalization wrong. Should I force-push with the correct capitalization? I imagine that'll need a new CI run. |
Hey sorry I missed that:
Sure, let's do that and re-run CI, it's not a rush but if it were we can land without re-running CI |
It's being deprecated and removed in V8.
Lowercased commit message and rebased. |
It's being deprecated and removed in V8.
See https://issues.chromium.org/u/1/issues/331326406.