doc: include followTags and GPG=TTY mention #52906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has happened in v20.13.0 release. Adding this doc to prevent edge cases where the releaser will sign and push but won't be able to promote the release.
|
Review requested:
|
RafaelGSS
force-pushed
the
doc-improve-release-process
branch
from
b46bbf8
to
a636af1
Compare
|
cc: @nodejs/releasers |
aduh95
reviewed
May 8, 2024
aduh95
reviewed
May 8, 2024
ShogunPanda
approved these changes
May 9, 2024
marco-ippolito
approved these changes
May 9, 2024
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS
added
the
commit-queue-squash
aduh95
approved these changes
May 12, 2024
aduh95
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in 06619aa |
targos
pushed a commit
that referenced
this pull request
May 12, 2024
This has happened in v20.13.0 release. Adding this doc to prevent edge cases where the releaser will sign and push but won't be able to promote the release. PR-URL: #52906 Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed these points missing while helping Marco in the last Node.js 20 release (v20.13.0)