Fix: support name attribute for smtp plugin #8412
Conversation
WalkthroughWalkthroughThe latest update to the SMTP plugin in NocoDB focuses on enhancing authentication flexibility by conditionally setting Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (1)
packages/nocodb/src/plugins/smtp/SMTP.ts (1)
Line range hint
16-31: Ensure consistent use of optional chaining for all properties in the configuration object.- name: this.input?.name, + name: this.input.name,
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/nocodb/src/plugins/smtp/SMTP.ts (2 hunks)
- packages/nocodb/src/plugins/smtp/index.ts (2 hunks)
Additional comments not posted (2)
packages/nocodb/src/plugins/smtp/index.ts (2)
10-10: Version increment to '0.0.3' is appropriate for reflecting the changes made.
33-39: Addition of the 'Name' field with appropriate settings is well-implemented.
Uffizzi Ephemeral Environment
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/nocodb/src/plugins/smtp/index.ts (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/nocodb/src/plugins/smtp/index.ts
| tls: { | ||
| rejectUnauthorized: this.input?.rejectUnauthorized, | ||
| }, | ||
| ...(this.input?.user ? { auth: { user: this.input?.user } } : {}), |
There was a problem hiding this comment.
is it user or username ? As per plugin meta it's username
There was a problem hiding this comment.
It's user. WIll update
There was a problem hiding this comment.
this.input?.user => this.input?.username
Change Summary
Provide summary of changes with issue number if any.
Closes #7103
Change type
Test/ Verification
Provide summary of changes.
Additional information / screenshots (optional)
Anything for maintainers to be made aware of