Fix dialyzer erros for cowboy 2.9.0 #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simple_bridge/src/cowboy_bridge_modules/cowboy_simple_bridge.erl
Line 117 Column 9:
The variable _ can never match since previous clauses completely covered the type #{binary()=>binary() | maybe_improper_list(binary() | maybe_improper_list(any(),binary() | []) | byte(),binary() | [])}
Line 166 Column 9: The pattern {'error', Reason} can never match the type {'more',binary(),#{'body_length':='undefined' | non_neg_integer(), ...
Line 177 Column 9: The pattern {H, L} can never match the type 'HTTP/2'
|
Hello, I'm not sure if this PR is too specific for cowboy 2.9.0. Maybe yes. In fact, how does simple_bridge detect and work with cowboy versions ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simple_bridge/src/cowboy_bridge_modules/cowboy_simple_bridge.erl
Line 117 Column 9:
The variable _ can never match since previous clauses completely covered the type #{binary()=>binary() | maybe_improper_list(binary() | maybe_improper_list(any(),binary() | []) | byte(),binary() | [])}
Line 166 Column 9: The pattern {'error', Reason} can never match the type {'more',binary(),#{'body_length':='undefined' | non_neg_integer(), ... Line 177 Column 9: The pattern {H, L} can never match the type 'HTTP/2'