Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): revise breaking changes content #3001

Closed
wants to merge 2 commits into from

Conversation

wingkwong
Copy link
Member

@wingkwong wingkwong commented May 14, 2024

Closes #

📝 Description

Add a brief description

⛳️ Current behavior (updates)

Please describe the current behavior that you are modifying

🚀 New behavior

Please describe the behavior or changes this PR adds

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

  • Improvements
    • Enhanced performance and reduced bundle size by removing units creation from the nextui plugin, leveraging TailwindCSS v3.4 support for min-h-* and min-w-* classes.
    • Improved validation handling by separating errorMessage and isInvalid, allowing for more precise validation feedback.

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 1:21pm
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 1:21pm

Copy link

changeset-bot bot commented May 14, 2024

⚠️ No Changeset found

Latest commit: 554673f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented May 14, 2024

Walkthrough

The recent updates in version 2.3.0 focus on enhancing performance and refining validation handling within the nextui plugin. Key changes include the removal of the units creation feature to optimize bundle size using TailwindCSS v3.4's new classes, and the improved management of validation messages by separating errorMessage from isInvalid.

Changes

Files Change Summary
apps/docs/content/blog/v2.3.0.mdx Removal of units creation and segregation of errorMessage from isInvalid for enhanced validation handling.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Out of diff range and nitpick comments (2)
apps/docs/content/blog/v2.3.0.mdx (2)

Line range hint 34-41: Fix the missing closing brackets for the links.

- [NextUI CLI](/docs/guide/cli) - A command-line interface for creating and managing NextUI projects.
- [DateInput](/docs/components/date-input) - Allows users to enter and edit date and time values using a keyboard.
- [TimeInput](/docs/components/time-input) - Allows users to enter and edit time values using a keyboard.
- [Calendar](/docs/components/calendar) - Displays a calendar for selecting dates and times.
- [RangeCalendar](/docs/components/range-calendar) - Displays a calendar for selecting date ranges.
- [DatePicker](/docs/components/date-picker) - Allows users to select a date from a calendar.
- [DateRangePicker](/docs/components/date-range-picker) - Allows users to select a date range from a calendar.
+ [NextUI CLI](/docs/guide/cli) - A command-line interface for creating and managing NextUI projects.
+ [DateInput](/docs/components/date-input) - Allows users to enter and edit date and time values using a keyboard.
+ [TimeInput](/docs/components/time-input) - Allows users to enter and edit time values using a keyboard.
+ [Calendar](/docs/components/calendar) - Displays a calendar for selecting dates and times.
+ [RangeCalendar](/docs/components/range-calendar) - Displays a calendar for selecting date ranges.
+ [DatePicker](/docs/components/date-picker) - Allows users to select a date from a calendar.
+ [DateRangePicker](/docs/components/date-range-picker) - Allows users to select a date range from a calendar.

Line range hint 95-95: Fix the typo "you setup" to "your setup".

- detect issues in you setup,
+ detect issues in your setup,
Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits Files that changed from the base of the PR and between 8988981 and b1a6a1a.
Files selected for processing (1)
  • apps/docs/content/blog/v2.3.0.mdx (2 hunks)
Additional Context Used
LanguageTool (43)
apps/docs/content/blog/v2.3.0.mdx (43)

Near line 34: Unpaired symbol: ‘[’ seems to be missing
Context: ... ## What's New in v2.3.0? - NextUI CLI - A command-line inter...


Near line 35: Unpaired symbol: ‘[’ seems to be missing
Context: ...d managing NextUI projects. - DateInput - Allows u...


Near line 36: Unpaired symbol: ‘[’ seems to be missing
Context: ...me values using a keyboard. - TimeInput - Allows u...


Near line 37: Unpaired symbol: ‘[’ seems to be missing
Context: ...ime values using a keyboard. - Calendar - Displays a...


Near line 38: Unpaired symbol: ‘[’ seems to be missing
Context: ...ecting dates and times. - RangeCalendar - Disp...


Near line 39: Unpaired symbol: ‘[’ seems to be missing
Context: ...for selecting date ranges. - DatePicker - Allows ...


Near line 40: Unpaired symbol: ‘[’ seems to be missing
Context: ...date from a calendar. - DateRangePicker - A...


Near line 41: Unpaired symbol: ‘[’ seems to be missing
Context: ... range from a calendar. - Other Changes - Includes styling impr...


Near line 47: Unpaired symbol: ‘[’ seems to be missing
Context: ...} /> Requirements: - Tailwind CSS 3.4 or later Upg...


Near line 95: “you” seems less likely than “your” (belonging to you).
Context: ...ts, remove components, detect issues in you setup, know your environment, and more....


Near line 118: Use a comma before “and” if it connects two independent clauses (unless they are closely connected and short).
Context: ...``` Select the template you want to use and the CLI will create a new project for y...


Near line 147: Consider using a different verb to strengthen your wording.
Context: ... more features and improvements. If you find any issues or have any suggestions, ple...


Near line 221: The pronoun ‘they’ must be used with a non-third-person form of a verb.
Context: ...ime zones and granularity support, they supports selecting dates in many calendar system...


Near line 227: “and” (in addition to, following this) seems less likely than “an” (indefinite article before a vowel sound).
Context: ...s into ZonedDateTime objects. Here's and example using the Indian calendar sys...


Near line 230: Consider adding a comma after ‘Alternatively’ for more clarity.
Context: ...ickerContent.internationalCalendar} /> Alternatively you can set the locale globally by us...


Near line 301: Consider a shorter alternative to avoid wordiness.
Context: ...s ### Removal of the units creation In order to improve the performance and reduce the ...


Near line 347: Consider a shorter alternative to avoid wordiness.
Context: ...he errorMessage. How to upgrade: 1. In order to display errorMessage, isInvalid has...


Near line 370: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2702) - [@wingkwong](https://github.com/wingkwong...


Near line 371: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2677) - @u3u - Patched ...


Near line 372: Consider using a different verb for a more formal wording.
Context: ...e "@nextui-org/autocomplete" package to fix an issue where empty items with `allowC...


Near line 372: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2674) - [@wingkwong](https://github.com/wingkwong...


Near line 373: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2709) - [@ryo-manba](https://github.com/ryo-manba...


Near line 374: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2709) - [@ryo-manba](https://github.com/ryo-manba...


Near line 375: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2649) - [@wingkwong](https://github.com/wingkwong...


Near line 376: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2648) - [@wingkwong](https://github.com/wingkwong...


Near line 377: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2595) - [@wingkwong](https://github.com/wingkwong...


Near line 378: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2553) - [@novsource](https://github.com/novsource...


Near line 379: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2450) - [@wingkwong](https://github.com/wingkwong...


Near line 382: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2464) - @mezotv - `L...


Near line 384: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2713) - [@jrgarciadev](https://github.com/jrgarci...


Near line 385: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2596) - [@wingkwong](https://github.com/wingkwong...


Near line 386: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2596) - [@wingkwong](https://github.com/wingkwong...


Near line 387: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2596) - [@wingkwong](https://github.com/wingkwong...


Near line 388: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2589) - [@wingkwong](https://github.com/wingkwong...


Near line 389: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2561) - [@ryo-manba](https://github.com/ryo-manba...


Near line 390: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2669) - [@wingkwong](https://github.com/wingkwong...


Near line 391: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2669) - [@wingkwong](https://github.com/wingkwong...


Near line 392: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2669) - [@wingkwong](https://github.com/wingkwong...


Near line 393: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2482) - @mrbadri - ...


Near line 394: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2485) - @mrbadri - ...


Near line 395: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2498) - @mrbadri - ...


Near line 396: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2472) - @mrbadri *...


Near line 401: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2428) - [@wingkwong](https://github.com/sudongyue...

Additional comments not posted (1)
apps/docs/content/blog/v2.3.0.mdx (1)

Line range hint 47-47: LGTM!

apps/docs/content/blog/v2.3.0.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Out of diff range and nitpick comments (27)
apps/docs/content/blog/v2.3.0.mdx (27)

Line range hint 370-370: Add the missing closing bracket for the link.

- [PR](https://github.com/nextui-org/nextui/pull/2702) - [@wingkwong](https://github.com/wingkwong
+ [PR](https://github.com/nextui-org/nextui/pull/2702) - [@wingkwong](https://github.com/wingkwong)

Line range hint 371-371: Add the missing closing bracket for the link.

- [PR](https://github.com/nextui-org/nextui/pull/2677) - [@u3u](https://github.com/u3u
+ [PR](https://github.com/nextui-org/nextui/pull/2677) - [@u3u](https://github.com/u3u)

Line range hint 372-372: Add the missing closing bracket for the link.

- [PR](https://github.com/nextui-org/nextui/pull/2674) - [@wingkwong](https://github.com/wingkwong
+ [PR](https://github.com/nextui-org/nextui/pull/2674) - [@wingkwong](https://github.com/wingkwong)

Line range hint 373-373: Add the missing closing bracket for the link.

- [PR](https://github.com/nextui-org/nextui/pull/2709) - [@ryo-manba](https://github.com/ryo-manba
+ [PR](https://github.com/nextui-org/nextui/pull/2709) - [@ryo-manba](https://github.com/ryo-manba)

Line range hint 374-374: Add the missing closing bracket for the link.

- [PR](https://github.com/nextui-org/nextui/pull/2709) - [@ryo-manba](https://github.com/ryo-manba
+ [PR](https://github.com/nextui-org/nextui/pull/2709) - [@ryo-manba](https://github.com/ryo-manba)

Line range hint 375-375: Add the missing closing bracket for the link.

- [PR](https://github.com/nextui-org/nextui/pull/2649) - [@wingkwong](https://github.com/wingkwong
+ [PR](https://github.com/nextui-org/nextui/pull/2649) - [@wingkwong](https://github.com/wingkwong)

Line range hint 376-376: Add the missing closing bracket for the link.

- [PR](https://github.com/nextui-org/nextui/pull/2648) - [@wingkwong](https://github.com/wingkwong
+ [PR](https://github.com/nextui-org/nextui/pull/2648) - [@wingkwong](https://github.com/wingkwong)

Line range hint 377-377: Add the missing closing bracket for the link.

- [PR](https://github.com/nextui-org/nextui/pull/2595) - [@wingkwong](https://github.com/wingkwong
+ [PR](https://github.com/nextui-org/nextui/pull/2595) - [@wingkwong](https://github.com/wingkwong)

Line range hint 378-378: Add the missing closing bracket for the link.

- [PR](https://github.com/nextui-org/nextui/pull/2553) - [@novsource](https://github.com/novsource
+ [PR](https://github.com/nextui-org/nextui/pull/2553) - [@novsource](https://github.com/novsource)

Line range hint 379-379: Add the missing closing bracket for the link.

- [PR](https://github.com/nextui-org/nextui/pull/2450) - [@wingkwong](https://github.com/wingkwong
+ [PR](https://github.com/nextui-org/nextui/pull/2450) - [@wingkwong](https://github.com/wingkwong)

Line range hint 382-382: Add the missing closing bracket for the link.

- [PR](https://github.com/nextui-org/nextui/pull/2464) - [@mezotv](https://github.com/mezotv
+ [PR](https://github.com/nextui-org/nextui/pull/2464) - [@mezotv](https://github.com/mezotv)

Line range hint 384-384: Add the missing closing bracket for the link.

- [PR](https://github.com/nextui-org/nextui/pull/2713) - [@jrgarciadev](https://github.com/jrgarci
+ [PR](https://github.com/nextui-org/nextui/pull/2713) - [@jrgarciadev](https://github.com/jrgarciadev)

Line range hint 385-385: Add the missing closing bracket for the link.

- [PR](https://github.com/nextui-org/nextui/pull/2596) - [@wingkwong](https://github.com/wingkwong
+ [PR](https://github.com/nextui-org/nextui/pull/2596) - [@wingkwong](https://github.com/wingkwong)

Line range hint 386-386: Add the missing closing bracket for the link.

- [PR](https://github.com/nextui-org/nextui/pull/2596) - [@wingkwong](https://github.com/wingkwong
+ [PR](https://github.com/nextui-org/nextui/pull/2596) - [@wingkwong](https://github.com/wingkwong)

Line range hint 387-387: Add the missing closing bracket for the link.

- [PR](https://github.com/nextui-org/nextui/pull/2596) - [@wingkwong](https://github.com/wingkwong
+ [PR](https://github.com/nextui-org/nextui/pull/2596) - [@wingkwong](https://github.com/wingkwong)

Line range hint 388-388: Add the missing closing bracket for the link.

- [PR](https://github.com/nextui-org/nextui/pull/2589) - [@wingkwong](https://github.com/wingkwong
+ [PR](https://github.com/nextui-org/nextui/pull/2589) - [@wingkwong](https://github.com/wingkwong)

Line range hint 389-389: Add the missing closing bracket for the link.

- [PR](https://github.com/nextui-org/nextui/pull/2561) - [@ryo-manba](https://github.com/ryo-manba
+ [PR](https://github.com/nextui-org/nextui/pull/2561) - [@ryo-manba](https://github.com/ryo-manba)

Line range hint 390-390: Add the missing closing bracket for the link.

- [PR](https://github.com/nextui-org/nextui/pull/2669) - [@wingkwong](https://github.com/wingkwong
+ [PR](https://github.com/nextui-org/nextui/pull/2669) - [@wingkwong](https://github.com/wingkwong)

Line range hint 391-391: Add the missing closing bracket for the link.

- [PR](https://github.com/nextui-org/nextui/pull/2669) - [@wingkwong](https://github.com/wingkwong
+ [PR](https://github.com/nextui-org/nextui/pull/2669) - [@wingkwong](https://github.com/wingkwong)

Line range hint 392-392: Add the missing closing bracket for the link.

- [PR](https://github.com/nextui-org/nextui/pull/2669) - [@wingkwong](https://github.com/wingkwong
+ [PR](https://github.com/nextui-org/nextui/pull/2669) - [@wingkwong](https://github.com/wingkwong)

Line range hint 393-393: Add the missing closing bracket for the link.

- [PR](https://github.com/nextui-org/nextui/pull/2482) - [@mrbadri](https://github.com/mrbadri
+ [PR](https://github.com/nextui-org/nextui/pull/2482) - [@mrbadri](https://github.com/mrbadri)

Line range hint 394-394: Add the missing closing bracket for the link.

- [PR](https://github.com/nextui-org/nextui/pull/2485) - [@mrbadri](https://github.com/mrbadri
+ [PR](https://github.com/nextui-org/nextui/pull/2485) - [@mrbadri](https://github.com/mrbadri)

Line range hint 395-395: Add the missing closing bracket for the link.

- [PR](https://github.com/nextui-org/nextui/pull/2498) - [@mrbadri](https://github.com/mrbadri
+ [PR](https://github.com/nextui-org/nextui/pull/2498) - [@mrbadri](https://github.com/mrbadri)

Line range hint 396-396: Add the missing closing bracket for the link.

- [PR](https://github.com/nextui-org/nextui/pull/2472) - [@mrbadri](https://github.com/mrbadri
+ [PR](https://github.com/nextui-org/nextui/pull/2472) - [@mrbadri](https://github.com/mrbadri)

Line range hint 221-221: Correct the verb agreement.

- These new components have built-in internationalization, time zones and granularity support, they supports selecting dates
+ These new components have built-in internationalization, time zones and granularity support, they support selecting dates

Line range hint 227-227: Correct the article usage.

- Here's and example using the `Indian` calendar system:
+ Here's an example using the `Indian` calendar system:

Line range hint 230-230: Add a comma after "Alternatively" for clarity.

- Alternatively you can set the `locale` globally by using the `NextUIProvider` component:
+ Alternatively, you can set the `locale` globally by using the `NextUIProvider` component:
Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits Files that changed from the base of the PR and between b1a6a1a and 554673f.
Files selected for processing (1)
  • apps/docs/content/blog/v2.3.0.mdx (2 hunks)
Additional Context Used
LanguageTool (41)
apps/docs/content/blog/v2.3.0.mdx (41)

Near line 34: Unpaired symbol: ‘[’ seems to be missing
Context: ... ## What's New in v2.3.0? - NextUI CLI - A command-line inter...


Near line 35: Unpaired symbol: ‘[’ seems to be missing
Context: ...d managing NextUI projects. - DateInput - Allows u...


Near line 36: Unpaired symbol: ‘[’ seems to be missing
Context: ...me values using a keyboard. - TimeInput - Allows u...


Near line 37: Unpaired symbol: ‘[’ seems to be missing
Context: ...ime values using a keyboard. - Calendar - Displays a...


Near line 38: Unpaired symbol: ‘[’ seems to be missing
Context: ...ecting dates and times. - RangeCalendar - Disp...


Near line 39: Unpaired symbol: ‘[’ seems to be missing
Context: ...for selecting date ranges. - DatePicker - Allows ...


Near line 40: Unpaired symbol: ‘[’ seems to be missing
Context: ...date from a calendar. - DateRangePicker - A...


Near line 41: Unpaired symbol: ‘[’ seems to be missing
Context: ... range from a calendar. - Other Changes - Includes styling impr...


Near line 47: Unpaired symbol: ‘[’ seems to be missing
Context: ...} /> Requirements: - Tailwind CSS 3.4 or later Upg...


Near line 118: Use a comma before “and” if it connects two independent clauses (unless they are closely connected and short).
Context: ...``` Select the template you want to use and the CLI will create a new project for y...


Near line 139: Possible missing comma found.
Context: ...ou can alternatively install the main package which includes all the components by pa...


Near line 147: Consider using a different verb to strengthen your wording.
Context: ... more features and improvements. If you find any issues or have any suggestions, ple...


Near line 221: The pronoun ‘they’ must be used with a non-third-person form of a verb.
Context: ...ime zones and granularity support, they supports selecting dates in many calendar system...


Near line 227: “and” (in addition to, following this) seems less likely than “an” (indefinite article before a vowel sound).
Context: ...s into ZonedDateTime objects. Here's and example using the Indian calendar sys...


Near line 230: Consider adding a comma after ‘Alternatively’ for more clarity.
Context: ...ickerContent.internationalCalendar} /> Alternatively you can set the locale globally by us...


Near line 370: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2702) - [@wingkwong](https://github.com/wingkwong...


Near line 371: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2677) - @u3u - Patched ...


Near line 372: Consider using a different verb for a more formal wording.
Context: ...e "@nextui-org/autocomplete" package to fix an issue where empty items with `allowC...


Near line 372: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2674) - [@wingkwong](https://github.com/wingkwong...


Near line 373: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2709) - [@ryo-manba](https://github.com/ryo-manba...


Near line 374: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2709) - [@ryo-manba](https://github.com/ryo-manba...


Near line 375: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2649) - [@wingkwong](https://github.com/wingkwong...


Near line 376: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2648) - [@wingkwong](https://github.com/wingkwong...


Near line 377: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2595) - [@wingkwong](https://github.com/wingkwong...


Near line 378: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2553) - [@novsource](https://github.com/novsource...


Near line 379: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2450) - [@wingkwong](https://github.com/wingkwong...


Near line 382: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2464) - @mezotv - `L...


Near line 384: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2713) - [@jrgarciadev](https://github.com/jrgarci...


Near line 385: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2596) - [@wingkwong](https://github.com/wingkwong...


Near line 386: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2596) - [@wingkwong](https://github.com/wingkwong...


Near line 387: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2596) - [@wingkwong](https://github.com/wingkwong...


Near line 388: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2589) - [@wingkwong](https://github.com/wingkwong...


Near line 389: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2561) - [@ryo-manba](https://github.com/ryo-manba...


Near line 390: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2669) - [@wingkwong](https://github.com/wingkwong...


Near line 391: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2669) - [@wingkwong](https://github.com/wingkwong...


Near line 392: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2669) - [@wingkwong](https://github.com/wingkwong...


Near line 393: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2482) - @mrbadri - ...


Near line 394: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2485) - @mrbadri - ...


Near line 395: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2498) - @mrbadri - ...


Near line 396: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2472) - @mrbadri *...


Near line 401: Unpaired symbol: ‘]’ seems to be missing
Context: ...thub.com//pull/2428) - [@wingkwong](https://github.com/sudongyue...

@@ -297,7 +297,9 @@ export function Providers({children}: ProvidersProps) {

## Breaking Changes

In order to improve the performance and reduce the bundle size, we have removed the `units` creation from the
### Removal of the `units` creation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplify the phrase "In order to".

- In order to improve the performance and reduce the bundle size,
+ To improve performance and reduce bundle size,

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
To improve performance and reduce bundle size,

Comment on lines +342 to +344
We are currently working on supporting multiple types of validation, including native HTML constraint validation, custom validation, and real-time validation.
Due to this reason, the requirements for displaying error messages have become more varied, and it is necessary to handle validation conditions separately from the `errorMessage`.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplify the phrase "Due to this reason".

- Due to this reason, the requirements for displaying error messages have become more varied, and it is necessary to handle validation conditions separately from the `errorMessage`.
+ Therefore, the requirements for displaying error messages have become more varied, and it is necessary to handle validation conditions separately from the `errorMessage`.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
We are currently working on supporting multiple types of validation, including native HTML constraint validation, custom validation, and real-time validation.
Due to this reason, the requirements for displaying error messages have become more varied, and it is necessary to handle validation conditions separately from the `errorMessage`.
We are currently working on supporting multiple types of validation, including native HTML constraint validation, custom validation, and real-time validation.
Therefore, the requirements for displaying error messages have become more varied, and it is necessary to handle validation conditions separately from the `errorMessage`.


How to upgrade:

1. To display `errorMessage`, `isInvalid` must be set to `true`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplify the phrase "In order to".

- In order to display `errorMessage`, `isInvalid` has to be set to `true`.
+ To display `errorMessage`, `isInvalid` must be set to `true`.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
1. To display `errorMessage`, `isInvalid` must be set to `true`.
1. To display `errorMessage`, `isInvalid` must be set to `true`.

@jrgarciadev jrgarciadev changed the base branch from canary to main May 15, 2024 15:06
@jrgarciadev jrgarciadev changed the base branch from main to canary May 15, 2024 15:06
@jrgarciadev
Copy link
Member

@wingkwong send this changes from main instead of canary

@wingkwong wingkwong changed the base branch from canary to main May 15, 2024 15:08
@wingkwong
Copy link
Member Author

@wingkwong send this changes from main instead of canary

Updated

@wingkwong wingkwong changed the base branch from main to canary May 25, 2024 01:17
@wingkwong wingkwong closed this May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants