Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to WolfSSL (Step 1) #17516

Merged
merged 29 commits into from May 16, 2024
Merged

Support to WolfSSL (Step 1) #17516

merged 29 commits into from May 16, 2024

Conversation

thiagoftsm
Copy link
Contributor

@thiagoftsm thiagoftsm commented Apr 25, 2024

Summary

Fixes #6509

This PR is also fixing some issues when we compile netdata disabling ACLK.

Test Plan
  1. Before to compile and test this branch, it is necessary to install wolfssl on your system. The default compilation of the library won't allow everything necessary to have ACLK debug messages and cloud, to fix this I compiled it using the following options:
# ./autogen.sh
# CFLAGS="-DOPENSSL_EXTRA -DHAVE_SECRET_CALLBACK -DWOLFSSL_TRUST_PEER_CERT" ./configure --prefix=/usr --enable-all --enable-static --enable-iopool --enable-secure-renegotiation --enable-sni
# make  CFLAGS="-DOPENSSL_EXTRA -DHAVE_SECRET_CALLBACK -DWOLFSSL_TRUST_PEER_CERT"
# make install
# ldconfig
  1. Compile this branch without to modify any option.
  2. Compile this branch enabling Wolfssl .
  3. To confirm that this PR is working, you can access our API (https://localhost:19999/api/v1/info). It is suggested to use info endpoint, because you can test both SSL and streaming with it.
Additional Information

To support ACLK and cloud, it will be necessary to do more changes in the source code. So this is the first step to bring the library.

For users: How does this change affect me?

@thiagoftsm thiagoftsm marked this pull request as draft April 25, 2024 06:13
@github-actions github-actions bot added area/daemon area/database area/aclk area/build Build system (autotools and cmake). labels Apr 25, 2024
@thiagoftsm thiagoftsm requested review from Ferroin and removed request for a team, vkalintiris and stelfrag April 25, 2024 06:13
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated
Comment on lines 165 to 164
# OSSL_DECODER_CTX does not exist in WolfSSL
set(ENABLE_ACLK False)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is likely fine for an initial implementation, but we ideally need to update the ACLK code to work with WolfSSL.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. We will need to modify our code, but I decide to proceed as a first step.

src/daemon/buildinfo.c Outdated Show resolved Hide resolved
thiagoftsm added a commit to thiagoftsm/netdata that referenced this pull request Apr 25, 2024
thiagoftsm added a commit to thiagoftsm/netdata that referenced this pull request Apr 26, 2024
thiagoftsm added a commit to thiagoftsm/netdata that referenced this pull request Apr 26, 2024
@github-actions github-actions bot added the area/packaging Packaging and operating systems support label Apr 26, 2024
thiagoftsm added a commit to thiagoftsm/netdata that referenced this pull request Apr 26, 2024
thiagoftsm added a commit to thiagoftsm/netdata that referenced this pull request Apr 27, 2024
thiagoftsm added a commit to thiagoftsm/netdata that referenced this pull request Apr 27, 2024
thiagoftsm added a commit to thiagoftsm/netdata that referenced this pull request Apr 27, 2024
thiagoftsm added a commit to thiagoftsm/netdata that referenced this pull request Apr 27, 2024
thiagoftsm added a commit to thiagoftsm/netdata that referenced this pull request Apr 28, 2024
thiagoftsm added a commit to thiagoftsm/netdata that referenced this pull request Apr 28, 2024
thiagoftsm added a commit to thiagoftsm/netdata that referenced this pull request Apr 28, 2024
thiagoftsm added a commit to thiagoftsm/netdata that referenced this pull request Apr 28, 2024
@thiagoftsm thiagoftsm requested a review from Ferroin May 14, 2024 23:17
@thiagoftsm thiagoftsm merged commit 8d9c464 into netdata:master May 16, 2024
148 of 153 checks passed
@thiagoftsm thiagoftsm deleted the use_wolfssl branch May 16, 2024 12:15
stelfrag added a commit that referenced this pull request May 17, 2024
stelfrag added a commit that referenced this pull request May 17, 2024
Revert "Support to WolfSSL (Step 1) (#17516)"

This reverts commit 8d9c464.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for other TLS/SSL libraries than OpenSSL
3 participants