Support handling of Abseil independently of Protobuf. #17414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/packaging
|
Rebased to resolve merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is needed for otel support.
If Protobuf gets vendored, we unconditionally vendor Abseil as well to avoid the possibility of conflicts from mixing versions. Otherwise, we try to find a usable copy on the system itself, and if we can’t we pull a vendored copy.
Detection is keyed off of the specific list of required components. For the moment this adds all requested components to all targets that it is asked to link Abseil to, target-specific component lists will be revisited if we add any other code that depends on Abseil.
Test Plan
CI passes on this PR.
Any further testing requires the otel support code