Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplementing sdfstudio into nerfstudio (Neuralangelo) #2440

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Reimplementing sdfstudio into nerfstudio (Neuralangelo) #2440

wants to merge 5 commits into from

Conversation

AdamRashid96
Copy link
Contributor

  • Going to move over and refactor all of the sdfstudio codebase
  • Might be good to incrementally merge the code into main
  • Starting with sdfstudio's implementation of Neuralangelo
  • About 10ms per step lower (Not sure why yet)
  • Still want to refactor the model and field

tancik
tancik reviewed Sep 19, 2023
View reviewed changes
nerfstudio/data/dataparsers/sdfstudio_dataparser.py Outdated
@@ -1,4 +1,4 @@
# Copyright 2022 the Regents of the University of California, Nerfstudio Team and contributors. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid changing the license header

@jkulhanek
Copy link
Contributor

How do the methods compare (sdfstudio vs this PR)?

@nepfaff
Copy link
Contributor

nepfaff commented Oct 6, 2023

Would be great to have Neuralangelo in Nerfstudio 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tancik tancik tancik left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AdamRashid96 @jkulhanek @nepfaff @tancik