feat(scanner): parse isrc and upc tag #2994
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zibbp <zibbp@zibbp.net>
Signed-off-by: Zibbp <zibbp@zibbp.net>
Signed-off-by: Zibbp <zibbp@zibbp.net>
|
Hey, thanks for submitting this. I didn't accept it because I'm in the middle of rewriting the scanner (see #2709). I'm avoiding any changes to that part of code now, as I don't want to spend time on merging issues. Once the new scanner is ready, it will be easy to adapt your code to the new version. |
|
No worries, I saw your scanner PR after I made this. Looking forward to it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo item from #1036
Description
Parse the
isrcandupctags if available. I've added ISRC and UPC columns to themediafiletable, and a UPC column to thealbumtable. These are made available in the web interface by clicking "get info" for a track or album. I've updated thetest.mp3file, adding example ISRC and UPC tags. Updating the file caused some other fields to get slightly changed so I had to fix a taglib test. Not sure if you have a better way to add tags to these files without other tags getting slightly modified, but the best way I found was using mp3tag, instead of ffmpeg or id3v2.The ISRC and UPC are not available in the API for searching, I'm not sure if that is part of the OpenSubsonic spec. Maybe it can be included as a search filter for the native API?