Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to find a way to use netty callbacks and checks if netty buffer is ready to consume more information. Please review this small patch to #172
Example, how it could be used (where
client: SocketIOClient
, andctx
is context of nettyctx: ChannelHandlerContext
)In deep it uses netty futures and promises but outside only pure
java.util.concurrent.Future
and some new interfaces in the packagecom.corundumstudio.socketio.concurrent
in order to make it possible to use another implementation.