Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding option for custom executor #386

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

adding option for custom executor #386

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 3, 2016

This allows library user to choose what executor to use for the server.
In my case, my application makes sure that there are only 2 pools default FJP and one IO thread pool (which has lots of custom telemetry and other custom logic). Most importantly it ensures that there is only one non daemon thread (main thread) everything else is daemon hence when main thread is finished all the resource deallocation tasks which were previously scheduled to Runtime.shutDownHook()... will execute and application will shut down gracefully.

However if i use this library i will end up having another main method, which prevents application from shutting down. For libraries like this i think its important to give option to choose what executors are being used etc...

This change adds option to provide custom executor to Configuration, which will be used to create netty event loop groups...

@mrniko
Copy link
Owner

mrniko commented Aug 3, 2016

Maybe it would be better to allow user set custom EventLoopGroup instead of Executor?

@ghost
Copy link
Author

ghost commented Aug 4, 2016

Up to you, currently i'm using the snapshot from this pull request, but i hope there will be some way to pass an executor.

@ghost
Copy link
Author

ghost commented Aug 4, 2016

Oh i mean some way to choose execution context. ELG seems like an implementation detail to me, not everyone know about it but everyone know what the Executor is :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant