-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stdlib] Apply any()
/all()
for SIMD
cases
#2735
Conversation
oh, should i have ran the notebook once after clearing the outputs? i noticed the large -diff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup! Don't worry about the metatdata of the notebook. We're not always great about clearing the cells prior to it being checked in. That's one of the problems of checking in ipynb into version control if you're not careful.
!sync |
Signed-off-by: Max Brylski <helehex@gmail.com>
03afcfb
to
9e35736
Compare
!sync |
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
Landed in ee0bd6e! Thank you for your contribution 🎉 |
[External] [stdlib] Apply `any()`/`all()` for `SIMD` cases Switch to using the builtin `any()`/`all()` functions instead of `SIMD.reduce_and()`/`SIMD.reduce_or()` where applicable. This simplifies the code *and* reads very nice. I tested the mandelbrot notebook example to ensure it still works. Co-authored-by: Helehex <Helehex@gmail.com> Closes #2735 MODULAR_ORIG_COMMIT_REV_ID: d08203ce31e7d654c29bf09441845e2e1ed007dd
[External] [stdlib] Apply `any()`/`all()` for `SIMD` cases Switch to using the builtin `any()`/`all()` functions instead of `SIMD.reduce_and()`/`SIMD.reduce_or()` where applicable. This simplifies the code *and* reads very nice. I tested the mandelbrot notebook example to ensure it still works. Co-authored-by: Helehex <Helehex@gmail.com> Closes modularml#2735 MODULAR_ORIG_COMMIT_REV_ID: d08203ce31e7d654c29bf09441845e2e1ed007dd
[External] [stdlib] Apply `any()`/`all()` for `SIMD` cases Switch to using the builtin `any()`/`all()` functions instead of `SIMD.reduce_and()`/`SIMD.reduce_or()` where applicable. This simplifies the code *and* reads very nice. I tested the mandelbrot notebook example to ensure it still works. Co-authored-by: Helehex <Helehex@gmail.com> Closes #2735 MODULAR_ORIG_COMMIT_REV_ID: d08203ce31e7d654c29bf09441845e2e1ed007dd
Switch to using the builtin
any()
/all()
functions instead ofSIMD.reduce_and()
/SIMD.reduce_or()
where applicable. This simplifies the code and reads very nice.I tested the mandelbrot notebook example to ensure it still works.