-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stdlib] Apply Indexer trait to stdlib containers #2722
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you! Before I bring this is, could you please add a few tests for IntLiteral indexers, and also update the changelog (you could just modify your existing entry for Indexer
).
b0601b1
to
45d6318
Compare
Signed-off-by: Brian Grenier <grenierb96@gmail.com>
45d6318
to
f2e8f76
Compare
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
Landed in 9760431! Thank you for your contribution 🎉 |
[External] [stdlib] Apply Indexer trait to stdlib containers The second half of #2384 I have intentionally omitted `static_tuple.mojo` to avoid conflicting with #2677 Co-authored-by: bgreni <42788181+bgreni@users.noreply.github.com> Closes #2722 MODULAR_ORIG_COMMIT_REV_ID: 365298938b36c3f4f9ad0067dfcb3856de369875
[External] [stdlib] Apply Indexer trait to stdlib containers The second half of modularml#2384 I have intentionally omitted `static_tuple.mojo` to avoid conflicting with modularml#2677 Co-authored-by: bgreni <42788181+bgreni@users.noreply.github.com> Closes modularml#2722 MODULAR_ORIG_COMMIT_REV_ID: 365298938b36c3f4f9ad0067dfcb3856de369875
[External] [stdlib] Apply Indexer trait to stdlib containers The second half of #2384 I have intentionally omitted `static_tuple.mojo` to avoid conflicting with #2677 Co-authored-by: bgreni <42788181+bgreni@users.noreply.github.com> Closes #2722 MODULAR_ORIG_COMMIT_REV_ID: 365298938b36c3f4f9ad0067dfcb3856de369875
The second half of #2384
I have intentionally omitted
static_tuple.mojo
to avoid conflicting with #2677