Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pydantic V2 migration #9193

Merged
merged 3 commits into from May 13, 2024
Merged

Pydantic V2 migration #9193

merged 3 commits into from May 13, 2024

Conversation

hamishfagg
Copy link
Contributor

There are a few more things changed between pydantic V1 and V2. I've run through this migration guide: https://docs.pydantic.dev/latest/migration/

@dusvyat
Copy link
Contributor

dusvyat commented May 10, 2024

no 'pre' argument in model_validator, its been replaced with mode='before' see here

@hamishfagg
Copy link
Contributor Author

@dusvyat fixed those issues, can you take another look? Can test on https://dev.mindsdb.com too

Copy link
Contributor

@dusvyat dusvyat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@tmichaeldb tmichaeldb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, lgtm 🤩

@hamishfagg hamishfagg merged commit 6b4ef2a into main May 13, 2024
14 checks passed
@hamishfagg hamishfagg deleted the fix/pydantic_warning branch May 13, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants