New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide sensitive connection args #9192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only concern I have is that this PR affects all integrations and we don't have tests to verify if they work. Let me run some of the old health checks that we had for more then 30 integrations on this branch
@ZoranPandovski it does not change integrations itself, only move |
Yes, it only affects the GUI form, so e2e tests on GUI work with this PR. We can merge it |
Description
This PR allows to hide sensitive information from:
By default any listed arguments will be replaced with '******'. This behavior can be controlled by setting the
show_secrets
variable:Also, the
connection_args
andconnection_args_example
are extracted from the file with the handler and saved in a separate file. This allows us to process the arguments even if the handler cannot be imported.https://www.loom.com/share/630eec6626fc4e5c9b384504080b4541
Close #8623
Doc issue #9209
Type of change
(Please delete options that are not relevant)
Verification Process
To ensure the changes are working as expected:
Additional Media:
Checklist: