New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify web #9190
Verify web #9190
Conversation
# Conflicts: # mindsdb/integrations/handlers/web_handler/requirements.txt
@@ -0,0 +1,130 @@ | |||
import unittest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add some tests for CrawlerTable
? For it's select()
operation to be precise? Such as for correctly raising exceptions when a OR operator is included or when an invalid URL is passed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I will add them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ZoranPandovski Looks like there is a small flake issue to be resolved.
@MinuraPunchihewa Fixed, plus few more tests for SELECT |
Description
This PR enhances the Web handler with several updates:
Type of change
(Please delete options that are not relevant)
Additional Media:
Checklist: