New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Integration]: Fireworks ai Integration #9131
base: main
Are you sure you want to change the base?
Conversation
@quest-bot loot #9043 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Please check the above comments. Also, let's include unit tests and implement the embeddings https://readme.fireworks.ai/docs/querying-embeddings-models
|
||
Before proceeding, ensure the following prerequisites are met: | ||
|
||
1. Install MindsDB [locally via Docker](https://docs.mindsdb.com/setup/self-hosted/docker) or use [MindsDB Cloud](https://cloud.mindsdb.com/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove MindsDB Cloud as an option. For now keep Docker and Docker Desktop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it
@@ -0,0 +1,8 @@ | |||
supported_task = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use Pydantic for this. As an example check https://github.com/mindsdb/mindsdb/blob/staging/mindsdb/integrations/handlers/mysql_handler/settings.py
args = self.model_storage.json_get("args") | ||
|
||
|
||
response = self.connection.ChatCompletion.create( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add try-except to handle possible exceptions
args = self.model_storage.json_get("args") | ||
|
||
|
||
response = self.connection.ChatCompletion.create( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add try-except to handle possible exceptions
@@ -0,0 +1,8 @@ | |||
supported_task = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe change this to something more meaningfull too as: conversational or image mode?
Description
Created Fireworks.ai ML Integration.
Fixes #9043
Type of change
Verification Process
To ensure the changes are working as expected:
Additional Media:
Checklist:
Testing Screenshots: