Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a unittest for Jira integration #8931

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sekhar-Kumar-Dash
Copy link
Contributor

@Sekhar-Kumar-Dash Sekhar-Kumar-Dash commented Mar 15, 2024

Description

This PR creates a unittest for Jira Handler

Type of change

  • ⚡ New feature (non-breaking change which adds functionality)

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.
    image

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@Sekhar-Kumar-Dash
Copy link
Contributor Author

hey @MinuraPunchihewa please review this PR.

@hamishfagg
Copy link
Contributor

Can we please move the tests from /tests to the handler folder for this and the other similar PRs?
See the mysql handler for an example of where to put them. We're trying to make the handlers more self contained :)

@Sekhar-Kumar-Dash
Copy link
Contributor Author

Sekhar-Kumar-Dash commented Mar 18, 2024

Can we please move the tests from /tests to the handler folder for this and the other similar PRs? See the mysql handler for an example of where to put them. We're trying to make the handlers more self contained :)

hey @hamishfagg actually i was told to put this test files in /test folder

@MinuraPunchihewa
Copy link
Collaborator

Hey @hamishfagg,
When @Sekhar-Kumar-Dash reached out to me, I asked him to place the tests in the /tests directory. I apologize if this was an incorrect instruction. Have we decided to place the tests for handlers in their own folders?
CC: @ZoranPandovski

@hamishfagg
Copy link
Contributor

Yeah that is the plan moving forward - it makes it much easier to find tests relevant to a handler, and makes it easier to execute tests based on changed files.
Thanks

@MinuraPunchihewa
Copy link
Collaborator

Thank you for this info, @hamishfagg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants