Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: can't generate traceID when use noop exporter #33191

Merged
merged 1 commit into from
May 21, 2024
Merged

fix: can't generate traceID when use noop exporter #33191

merged 1 commit into from
May 21, 2024

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented May 20, 2024

relate: #33190

@aoiasd
fix can't generate traceID when use noop exporter
38538d1 
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label May 20, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 20, 2024
@codecov Codecov
Copy link

codecov bot commented May 20, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.17%. Comparing base (c35eaaa) to head (38538d1).
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #33191   +/-   ##
=======================================
  Coverage   82.17%   82.17%           
=======================================
  Files        1009     1009           
  Lines      128822   128819    -3     
=======================================
+ Hits       105856   105863    +7     
- Misses      18961    18968    +7     
+ Partials     4005     3988   -17
Files Coverage Δ
pkg/tracer/tracer.go 78.43% <ø> (-1.20%) ⬇️

... and 33 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 20, 2024
congqixia
congqixia approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit f8929cc into milvus-io:master May 21, 2024
15 checks passed
aoiasd added a commit to aoiasd/milvus that referenced this pull request May 21, 2024
@aoiasd
fix: can't generate traceID when use noop exporter (milvus-io#33191)
44804c2 
relate: milvus-io#33190

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
@aoiasd aoiasd mentioned this pull request May 21, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request May 22, 2024
@aoiasd
fix:[Cherry-Pick] can't generate traceID when use noop exporter (#33191…
1f23c39 
…) (#33208)

relate: #33190
pr: #33191

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@sunby sunby Awaiting requested review from sunby

@zwd1208 zwd1208 Awaiting requested review from zwd1208

Assignees

@congqixia congqixia

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aoiasd @sre-ci-robot @congqixia