Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: try best to get enough query results #33178

Merged
merged 1 commit into from
May 21, 2024
Merged

fix: try best to get enough query results #33178

merged 1 commit into from
May 21, 2024

Conversation

longjiquan
Copy link
Contributor

issue: #33137

@longjiquan
fix: try best to get enough query results
e0d56db 
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label May 20, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 20, 2024
longjiquan added a commit to longjiquan/milvus that referenced this pull request May 20, 2024
@longjiquan
fix: try best to get enough query results (milvus-io#33178)
be811fa 
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
@longjiquan longjiquan mentioned this pull request May 20, 2024
Merged
@sunby
Copy link
Contributor

sunby commented May 20, 2024

/lgtm

@codecov Codecov
Copy link

codecov bot commented May 20, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.16%. Comparing base (c35eaaa) to head (e0d56db).
Report is 8 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33178      +/-   ##
==========================================
- Coverage   82.17%   82.16%   -0.01%     
==========================================
  Files        1009     1009              
  Lines      128822   128823       +1     
==========================================
- Hits       105856   105853       -3     
- Misses      18961    18963       +2     
- Partials     4005     4007       +2
Files Coverage Δ
internal/proxy/task_query.go 81.71% <100.00%> (+0.04%) ⬆️

... and 31 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 20, 2024
@czs007
Copy link
Contributor

czs007 commented May 21, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 9f81290 into milvus-io:master May 21, 2024
15 checks passed
sre-ci-robot pushed a commit that referenced this pull request May 21, 2024
@longjiquan
fix: try best to get enough query results (#33178) (#33179)
a27a2e8 
issue: #33137
pr: #33178

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
@longjiquan longjiquan deleted the fix-query-dup-pk-master branch May 21, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@sunby sunby

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@longjiquan @sunby @czs007 @sre-ci-robot