Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: try best to get enough query results #33177

Merged
merged 3 commits into from
May 21, 2024

Conversation

longjiquan
Copy link
Contributor

@longjiquan longjiquan commented May 20, 2024

issue: #33137
pr: #32567
Co-authored-by: sunby bingyi.sun@zilliz.com
Co-authored-by: MrPresent-Han chun.han@zilliz.com

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label May 20, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 20, 2024
@longjiquan
Copy link
Contributor Author

rerun ut

@yanliang567 yanliang567 added this to the 2.3.16 milestone May 20, 2024
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
Copy link
Contributor

mergify bot commented May 21, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@longjiquan
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 21, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@longjiquan
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.10%. Comparing base (7a617e2) to head (d975b78).
Report is 1 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.3   #33177   +/-   ##
=======================================
  Coverage   83.10%   83.10%           
=======================================
  Files         850      850           
  Lines      106653   106711   +58     
=======================================
+ Hits        88631    88680   +49     
- Misses      14725    14728    +3     
- Partials     3297     3303    +6     
Files Coverage Δ
internal/proxy/task_query.go 80.05% <100.00%> (+0.05%) ⬆️
internal/querynodev2/segments/result.go 77.98% <100.00%> (+0.33%) ⬆️

... and 17 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 21, 2024
@czs007
Copy link
Contributor

czs007 commented May 21, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 76b7c23 into milvus-io:2.3 May 21, 2024
14 checks passed
@longjiquan longjiquan deleted the fix-query-dup-pk branch May 21, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants