fix: Remove L0 compactor in completedCompactor #33169
Conversation
See also: milvus-io#33168 Signed-off-by: yangxuan <xuan.yang@zilliz.com>
mergify
bot
added
dco-passed
|
@XuanYang-cn E2e jenkins job failed, comment |
| lo.ForEach(completedLevelZero, func(planID int64, _ int) { | ||
| c.completed.Remove(planID) | ||
| c.completedCompactor.Remove(planID) |
There was a problem hiding this comment.
should this be removed by injectDone?
There was a problem hiding this comment.
L0 compaction has no call back, so won't be called SyncSegments, and won't be called injectDone.
Althrough its weired to remove in get, but it's only communication DC and DN will do on L0 compaction, so it's the only chance to remove the l0 tasks in DN memory by Get.
|
/run-cpu-e2e |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #33169 +/- ##
==========================================
- Coverage 82.18% 81.86% -0.33%
==========================================
Files 1009 1009
Lines 128806 128823 +17
==========================================
- Hits 105860 105456 -404
- Misses 18953 19371 +418
- Partials 3993 3996 +3
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
See also: milvus-io#33168 pr: milvus-io#33169 Signed-off-by: yangxuan <xuan.yang@zilliz.com>
See also: #33168