Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Version: RARLab.WinRAR version 7.01 #154148

Merged
merged 2 commits into from
May 20, 2024
Merged

New Version: RARLab.WinRAR version 7.01 #154148

merged 2 commits into from
May 20, 2024

Conversation

og-mrk
Copy link
Contributor

@og-mrk og-mrk commented May 18, 2024 •
edited

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Possible-Duplicate Manifest-Metadata-Consistency New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain labels May 18, 2024
@wingetbot
Copy link
Collaborator

Possible duplicate package entry.

Similar installer SHA256 hash found in manifest:

  • InstallerSha256: eec5777d43ea0b23d29fd8e472d5a0d5e3ea0f6c5969c849361d8f029e277278
    • manifests\r\RARLab\WinRAR\7.00.0
  • InstallerSha256: 9747391241eacf2f6bfa9e481382a31c63ad467ab8e5b53a8efff5654140874a
    • manifests\r\RARLab\WinRAR\7.00.0
  • InstallerSha256: adc067acb1da85a5404e0c15e0bf7192bcb21c3b4c8ef789ba8f7b09c725c54b
    • manifests\r\RARLab\WinRAR\7.00.0
  • InstallerSha256: bf8cca61ec5044d0fce4efbaa78eee3ae481d68a113aadda36fefbf5c5123c42
    • manifests\r\RARLab\WinRAR\7.00.0
  • InstallerSha256: 4d144c5acf9a637dad78012b396906005fea9f5674b6f2ed26854b3f62c4b4ab
    • manifests\r\RARLab\WinRAR\7.00.0
  • InstallerSha256: faf413a423bbd6539b220a4a207491fe28adcd0bd4d06e12f61808704931c589
    • manifests\r\RARLab\WinRAR\7.00.0
  • InstallerSha256: 76e5a1ebea460458d2b69294e0a38963eab23babfe3c79915454c2891ba807cd
    • manifests\r\RARLab\WinRAR\7.00.0
  • InstallerSha256: 780f46242804d97011e728dd9be2c8e43208bcd87f7f988f6ca8f062655d99f4
    • manifests\r\RARLab\WinRAR\7.00.0
  • InstallerSha256: 9c28c017b3ee910f8f1df91b0df13883f18dee383348cdadb3e7e3af15154622
    • manifests\r\RARLab\WinRAR\7.00.0
  • InstallerSha256: 79619a1b4357cb1bd66aa7e1490344c1a96ed4a19f3d5935ce83f4c8461f6fc9
    • manifests\r\RARLab\WinRAR\7.00.0
  • InstallerSha256: 7fd1609fec83e9fa4bbf9938687e8763cb48b17c6e9f53cf5b5d4efc8001df68
    • manifests\r\RARLab\WinRAR\7.00.0
  • InstallerSha256: 837c30d2574f5cabd03828457658d27d88a873b35dbaae2ec51f305853f910b3
    • manifests\r\RARLab\WinRAR\7.00.0

@wingetbot
Copy link
Collaborator

=== manifests\r\RARLab\WinRAR\7.01 ===
Missing Properties value based on version 7.00.0:
ReleaseDate

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 18, 2024
@og-mrk

This comment was marked as outdated.

Sign in to view
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels May 18, 2024
@og-mrk og-mrk force-pushed the new-manifest-version/RARLab.WinRAR-version7.01 branch from 16cc733 to 16c1553 Compare May 18, 2024 16:10
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Attention This work item needs to be reviewed by a member of the core team. Possible-Duplicate Manifest-Metadata-Consistency Validation-Domain New-Manifest labels May 18, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. Possible-Duplicate Validation-Domain New-Manifest labels May 19, 2024
@wingetbot wingetbot added Manifest-Metadata-Consistency New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain labels May 19, 2024
@wingetbot
Copy link
Collaborator

=== manifests\r\RARLab\WinRAR\7.01 ===
Missing Properties value based on version 7.00.0:
Installers

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 19, 2024
@og-mrk
Copy link
Contributor Author

og-mrk commented May 19, 2024 •
edited

Hello @og-mrk,

One or more of the installer URLs doesn't appear valid.

This may happen for sites with policies prohibiting distribution or use by third parties.

This may happen for URLs pointing to domains that do not align with the publisher domain or package domain. If you could provide supporting evidence from the publisher that the URLs for the installer are correct, that would help us to validate and approve this PR.

Template: msftbot/validationError/urls/domain

According to the logs, some of the URLs need to be validated manually, when I've created the Manifest using YAMLcreate.ps1 script, all the URLs for the installers I've validated, as they work on the time of package creation locally (at least, this's relative to the region of where I live), this validation problem in the testing pipeline could be because WinRAR servers blocking Azure's testing servers for one or more reasons.

Hope my feedback could be of any help to the maintainers, as other the above-mentioned explanation of mine, I can't see why the testing pipeline can't validate the URLs of this Manifest.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels May 19, 2024
@stephengillie stephengillie added Validation-Completed Validation passed and removed Validation-Domain labels May 20, 2024
@stephengillie
Copy link
Collaborator

My guess is that some of these are located under a /winrar subfolder, and that was confusing detection.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label May 20, 2024
@stephengillie stephengillie merged commit 571fbd6 into microsoft:master May 20, 2024
8 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label May 20, 2024
@og-mrk og-mrk deleted the new-manifest-version/RARLab.WinRAR-version7.01 branch May 20, 2024 22:26
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie approved these changes

Assignees

@og-mrk og-mrk

@stephengillie stephengillie

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Manifest-Metadata-Consistency Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Update Request]: WinRAR
3 participants
@og-mrk @wingetbot @stephengillie