Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Add cross language tests #6318

Merged
merged 15 commits into from
May 22, 2024
Merged

Conversation

moonbox3
Copy link
Contributor

Motivation and Context

As we move towards v1 and beyond it's essential that we have a way to make sure we are staying in line with the other SK SDKs. Previous to this we didn't have a way to capture request bodies and payloads and make sure they confirm to the proper SK standards.

Description

This PR introduces a number of integration tests that exercise various aspects of the SK SDK like prompts, prompt templates, functions, and the kernel.

TODO: update the OpenAPI tests with a more JSON specific response that we can check against.

Contribution Checklist

@moonbox3 moonbox3 requested a review from a team as a code owner May 17, 2024 18:42
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label May 17, 2024
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented May 17, 2024

Py3.10 Test Coverage

Python 3.10 Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel/connectors/ai/open_ai/services
   open_ai_chat_completion_base.py2129356%98, 118, 143–147, 171, 175, 191–196, 213–241, 244–255, 273–280, 291–299, 315–322, 343, 351, 357–363, 375–381, 412, 451, 453–454, 459–464, 468–475, 497, 506–515
TOTAL624696385% 

Python 3.10 Unit Test Overview

Tests Skipped Failures Errors Time
1350 1 💤 0 ❌ 0 🔥 15.275s ⏱️

Copy link
Member

@eavanvalkenburg eavanvalkenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small nits, but should be ok

@moonbox3 moonbox3 enabled auto-merge May 22, 2024 15:38
@moonbox3 moonbox3 added this pull request to the merge queue May 22, 2024
Merged via the queue into microsoft:main with commit d66fdcf May 22, 2024
25 checks passed
@moonbox3 moonbox3 deleted the cross_language_tests branch May 22, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants