-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Checkpoints to 02_qa_generation and 03_querying #555
Merged
guybartal
merged 55 commits into
prerelease
from
yuval/add_checkpoint_usage_to_additional_steps
May 18, 2024
Merged
Add Checkpoints to 02_qa_generation and 03_querying #555
guybartal
merged 55 commits into
prerelease
from
yuval/add_checkpoint_usage_to_additional_steps
May 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment-accelerator into yuval/add-local-checkpoints
…ment-accelerator into yuval/add-local-checkpoint-for-index
…ment-accelerator into yuval/add-local-checkpoint-for-index
…ment-accelerator into yuval/add-local-checkpoint-for-index
Co-authored-by: Martin Peck <martinjohnpeck@gmail.com>
…ment-accelerator into yuval/add-local-checkpoint-for-index
….com/microsoft/rag-experiment-accelerator into yuval/add-local-checkpoint-for-index
Co-authored-by: Guy Bertental <gubert@microsoft.com>
…eckpoint_usage_to_additional_steps
…ment-accelerator into yuval/add-local-checkpoint-for-index
…eckpoint_usage_to_additional_steps
…eckpoint_usage_to_additional_steps
guybartal
changed the base branch from
yuval/add-local-checkpoint-for-index
to
prerelease
May 18, 2024 14:48
guybartal
approved these changes
May 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Checkpoints to the
02_qa_generation
and03_querying
steps.The only code changes, other than the addition of the checkpoints, were to export code to methods so they could be wrapped with the checkpoint decorator. There are no functional changes in this PR.
01_index
index step is already covered as part of #472.The
04_evaluation
step is not covered, as a refactor will soon take place there.