Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Checkpoints to 02_qa_generation and 03_querying #555

Merged
merged 55 commits into from
May 18, 2024

Conversation

yuvalyaron
Copy link
Collaborator

Added Checkpoints to the 02_qa_generation and 03_querying steps.

The only code changes, other than the addition of the checkpoints, were to export code to methods so they could be wrapped with the checkpoint decorator. There are no functional changes in this PR.

01_index index step is already covered as part of #472.
The 04_evaluation step is not covered, as a refactor will soon take place there.

yuvalyaron and others added 30 commits April 10, 2024 13:26
Co-authored-by: Martin Peck <martinjohnpeck@gmail.com>
@yuvalyaron yuvalyaron marked this pull request as ready for review May 15, 2024 13:06
@guybartal guybartal self-assigned this May 16, 2024
@guybartal guybartal changed the base branch from yuval/add-local-checkpoint-for-index to prerelease May 18, 2024 14:48
Copy link
Collaborator

@guybartal guybartal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guybartal guybartal removed the request for review from ritesh-modi May 18, 2024 18:50
@guybartal guybartal merged commit 82d0fa1 into prerelease May 18, 2024
3 checks passed
@guybartal guybartal mentioned this pull request May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants