-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RAGAS evaluation metrics #504
Conversation
91d79f8
to
615997b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
I would rather @ritesh-modi give you a final approval, but from my point of view this should be approved and merged.
615997b
to
9069fc8
Compare
What was the reason for the force-push? |
@martinpeck The branch became outdated so rebased and pushed with --force-with-lease to avoid overwriting |
azure_deployment=azure_configs["embedding_deployment"], | ||
model=azure_configs["embedding_name"], | ||
) | ||
ragas_azure_embeddings = LangchainEmbeddingsWrapper(azure_embeddings) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it be done without using LangchainLLMWrapper and LangchainEMbeddingsWrapper?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. Since RAGAS can be used with different LLM models these wrappers help the RAGAS library implement a common interface used by the metrics. We could of course create our own implementation of the wrappers, but it would require duplicating a lot of existing logic and continuous monitoring of the RAGAS library for compatibility issues. Is there a specific reason why we would want not to import them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be evaluated because of new security guidance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ritesh-modi , we have many LangChain dependencies already which we need to resolve with priority,
I think we should open a new separate issue to address this across and not block this PR to prerelease branch.
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, if all comments are resolved, lets merge this to prerelease branch
As discussed, closing this PR per security guidance |
closes #317
This PR integrates RAGAS open source evaluation framework for RAG pipelines. The new added metrics offer support for both end-to-end and component-wise RAG evaluation:
This PR also fixes:
generate_metrics
query_and_eval_single_line