Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle numeric columns #3308

Merged
merged 5 commits into from
May 22, 2024
Merged

Handle numeric columns #3308

merged 5 commits into from
May 22, 2024

Conversation

nick863
Copy link
Contributor

@nick863 nick863 commented May 17, 2024 •
edited

Description

Handle the numeric columns in the evaluator output. See work item 3216567

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@nick863 nick863 requested a review from a team as a code owner May 17, 2024 20:51
ninghu
ninghu previously approved these changes May 17, 2024
View reviewed changes
singankit
singankit previously approved these changes May 17, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented May 17, 2024 •
edited

promptflow-evals test result

  9 files    9 suites   1h 20m 5s ⏱️
 39 tests  33 ✅  6 💤 0 ❌
351 runs  297 ✅ 54 💤 0 ❌

Results for commit 92e036d.

♻️ This comment has been updated with latest results.

@nick863 nick863 dismissed stale reviews from singankit and ninghu via 7530ec4 May 17, 2024 21:39
@singankit singankit merged commit 1e5a2c4 into main May 22, 2024
37 checks passed
@singankit singankit deleted the users/nirovins/handle_numeric_columns branch May 22, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninghu ninghu ninghu approved these changes

@singankit singankit singankit approved these changes

Assignees
No one assigned
Labels
promptflow-evals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nick863 @ninghu @singankit