Await onApiCallEnd/onApiCallBegin hooks
#30795
Conversation
| @@ -188,7 +189,7 @@ export abstract class ChannelOwner<T extends channels.Channel = channels.Channel | |||
| logApiCall(logger, `=> ${apiName} started`, isInternal); | |||
| const apiZone: ApiZone = { apiName, frames, isInternal, reported: false, csi, callCookie, wallTime }; | |||
| const result = await zones.run('apiZone', apiZone, async () => await func(apiZone)); | |||
| csi?.onApiCallEnd(callCookie); | |||
| await csi?.onApiCallEnd(callCookie); | |||
There was a problem hiding this comment.
similar issue happens here when this is not awaited - the test runs to completion, closes the browser and code in onApiCallEnd can get rejected with "Test ended." error because the browser was already closes by the time it gets executed
This comment has been minimized.
This comment has been minimized.
|
How did you discover this? We only have one instrumentation instance, so things should run in order. Starting with an issue would always be great as well! |
We are hooking into this not-so-stable API in our |
Test results for "tests 1"6 fatal errors, not part of any test 1 flaky5 interrupted10147 passed, 244 skipped, 16897 did not run Merge workflow run. |
|
Looks like the bots are unhappy with your approach. |
onApiCallBegindoesn't completely serve its purpose today.onApiCallBeginhook here so whatever gets installed after it gets executed in the next microtask (since this hook is synchronous). That means that the next hooks get called after the API call has already been dispatched since the engine exits from the non-awaited instrumentation wrapper call and proceeds tothis._connection.sendMessageToServer