-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: update Electron to v29 #30334
base: main
Are you sure you want to change the base?
test: update Electron to v29 #30334
Conversation
This comment has been minimized.
This comment has been minimized.
Archiving |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test results for "tests 2"4 fatal errors, not part of any test 48 flaky168872 passed, 7473 skipped, 2736 did not run Merge workflow run. |
Test results for "tests 1"1 flaky27406 passed, 608 skipped Merge workflow run. |
Electron 29 is the last supported version as of today: https://www.electronjs.org/docs/latest/tutorial/electron-timelines
(28 is EOL in 11 days and didn't get the backport were were relying on)
Most of the fixmes which were removed were related to
'error: Browser context management is not supported.'
which is fixed since electron/electron#41718.Fixes #12096
Blocked by electron/typescript-definitions#264