Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update Electron to v29 #30334

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Apr 11, 2024

Electron 29 is the last supported version as of today: https://www.electronjs.org/docs/latest/tutorial/electron-timelines

(28 is EOL in 11 days and didn't get the backport were were relying on)

Most of the fixmes which were removed were related to 'error: Browser context management is not supported.' which is fixed since electron/electron#41718.

Fixes #12096

Blocked by electron/typescript-definitions#264

This comment has been minimized.

@mxschmitt mxschmitt marked this pull request as draft April 11, 2024 14:39
@pavelfeldman
Copy link
Member

Archiving

@mxschmitt mxschmitt reopened this May 31, 2024
@mxschmitt mxschmitt changed the title test: update Electron to v27 test: update Electron to v29 May 31, 2024
@mxschmitt mxschmitt added the CQ1 label May 31, 2024
@mxschmitt mxschmitt marked this pull request as ready for review May 31, 2024 09:32

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

Test results for "tests 2"

4 fatal errors, not part of any test
4 failed
❌ [chromium-page] › page/page-drag.spec.ts💯5 › Drag and drop › should cancel on escape
❌ [firefox-page] › page/page-clock.spec.ts:570:3 › shouldAdvanceTime › should create an auto advancing timer
❌ [chromium-page] › page/page-drag.spec.ts:53:5 › Drag and drop › should not send dragover on the first mousemove
❌ [webkit-page] › page/page-drag.spec.ts💯5 › Drag and drop › should cancel on escape

48 flaky ⚠️ [chromium-library] › library/emulation-focus.spec.ts:202:12 › should trigger hover state concurrently
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:426:7 › cli codegen › should emit single keyup on ArrowDown
⚠️ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:22:7 › cli codegen › should click locator.first
⚠️ [chromium-page] › page/locator-misc-1.spec.ts:21:3 › should hover @smoke
⚠️ [chromium-page] › page/page-drag.spec.ts:246:5 › Drag and drop › should work if the drag event is captured but not canceled
⚠️ [chromium-page] › page/page-mouse.spec.ts:166:3 › should trigger hover state
⚠️ [chromium-library] › library/browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:790:7 › cli codegen › should click button with nested div
⚠️ [chromium-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [chromium-page] › page/page-mouse.spec.ts:166:3 › should trigger hover state
⚠️ [chromium-library] › library/inspector/cli-codegen-javascript.spec.ts:27:5 › should print the correct imports and context options
⚠️ [chromium-page] › page/page-goto.spec.ts:482:3 › should succeed on url bar navigation when there is pending navigation
⚠️ [firefox-page] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:57:7 › cli codegen › should click locator.nth
⚠️ [firefox-page] › page/page-add-locator-handler.spec.ts:210:5 › should work when owner frame detaches
⚠️ [firefox-library] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox-library] › library/tracing.spec.ts:292:5 › should overwrite existing file
⚠️ [firefox-page] › page/page-click.spec.ts:99:3 › should click the 1x1 div
⚠️ [firefox-page] › page/page-clock.spec.ts:140:3 › tick › passes 1 minute
⚠️ [firefox-page] › page/page-clock.spec.ts:570:3 › shouldAdvanceTime › should create an auto advancing timer
⚠️ [chromium-library] › library/capabilities.spec.ts:141:3 › should not crash on showDirectoryPicker
⚠️ [chromium-page] › page/locator-misc-1.spec.ts:21:3 › should hover @smoke
⚠️ [chromium-page] › page/page-drag.spec.ts:70:5 › Drag and drop › should work inside iframe
⚠️ [chromium-page] › page/page-drag.spec.ts:330:5 › Drag and drop › should work with locators
⚠️ [chromium-page] › page/page-mouse.spec.ts:166:3 › should trigger hover state
⚠️ [chromium-library] › library/capabilities.spec.ts:157:3 › should not crash on storage.getDirectory()
⚠️ [chromium-page] › page/page-add-locator-handler.spec.ts:281:5 › should wait for hidden by default 2
⚠️ [webkit-page] › page/page-clock.spec.ts:570:3 › shouldAdvanceTime › should create an auto advancing timer
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:324:7 › cli codegen › should fill [contentEditable]
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:383:7 › cli codegen › should generate getByTestId
⚠️ [webkit-page] › page/page-drag.spec.ts💯5 › Drag and drop › should cancel on escape
⚠️ [webkit-page] › page/page-drag.spec.ts:246:5 › Drag and drop › should work if the drag event is captured but not canceled
⚠️ [webkit-page] › page/page-drag.spec.ts:272:5 › Drag and drop › should work if a frame is stalled
⚠️ [webkit-page] › page/page-drag.spec.ts:289:5 › Drag and drop › should work with the helper method
⚠️ [webkit-page] › page/page-drag.spec.ts:330:5 › Drag and drop › should work with locators
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:197:7 › cli codegen › should not target selector preview by text regexp
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:531:7 › cli codegen › should consume pointer events
⚠️ [webkit-page] › page/page-drag.spec.ts:34:5 › Drag and drop › should send the right events
⚠️ [webkit-page] › page/page-drag.spec.ts:289:5 › Drag and drop › should work with the helper method
⚠️ [webkit-library] › library/browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:23:7 › cli codegen › should click
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:76:7 › cli codegen › should click after same-document navigation
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:197:7 › cli codegen › should not target selector preview by text regexp
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:22:7 › cli codegen › should click locator.first
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:415:7 › cli codegen › should generate getByPlaceholder
⚠️ [webkit-page] › page/page-drag.spec.ts:246:5 › Drag and drop › should work if the drag event is captured but not canceled
⚠️ [webkit-library] › library/tracing.spec.ts:412:14 › should produce screencast frames fit
⚠️ [webkit-page] › page/workers.spec.ts:243:3 › should support offline

168872 passed, 7473 skipped, 2736 did not run
✔️✔️✔️

Merge workflow run.

Copy link
Contributor

Test results for "tests 1"

1 flaky ⚠️ [playwright-test] › ui-mode-test-screencast.spec.ts:21:5 › should show screenshots

27406 passed, 608 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt marked this pull request as draft May 31, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Cookies not supported with Electron
2 participants