Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide scheduler_ptr to _ScheduleFuncWithAutoInline #1596

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

parkske
Copy link

@parkske parkske commented Mar 13, 2021

The ambient_scheduler may not be the desired scheduler to schedule
functions on, but _ScheduleFuncWithAutoInline does not offer any
other option. Provide a means to select a desired scheduler and
fall back to the ambient scheduler if not specified.

Related issue: #1595

@ghost
Copy link

ghost commented Mar 13, 2021

CLA assistant check
All CLA requirements met.

The ambient_scheduler may not be the desired scheduler to schedule
functions on, but _ScheduleFuncWithAutoInline does not offer any
other option. Provide a means to select a desired scheduler and
fall back to the ambient scheduler if not specified.
@parkske parkske force-pushed the parkske/i1595_specify_scheduler_ScheduleFuncWithAutoInline branch from baded66 to 1aa57c6 Compare March 13, 2021 01:56
@parkske parkske marked this pull request as ready for review March 30, 2021 17:25
@parkske
Copy link
Author

parkske commented Mar 31, 2021

@BillyONeal could you have a look? We ran into this when trying to pin tasks to a specific scheduler. Unsure if we're missing a case when the workflow requires use of the Ambient scheduler.

@BillyONeal
Copy link
Member

@BillyONeal could you have a look? We ran into this when trying to pin tasks to a specific scheduler. Unsure if we're missing a case when the workflow requires use of the Ambient scheduler.

I am no longer directly affiliated with cpprestsdk. If I still were I would be concerned about making API changes to pplx parts unless they can be exactly replicated in ppl, because pplx's API contract is 'exactly ppl but works on other platforms'.

@barcharcraz
Copy link
Member

Can you verify what ppl tasks does natively in this situation?

@parkske
Copy link
Author

parkske commented Jul 6, 2021

Can you verify what ppl tasks does natively in this situation?

@barcharcraz Is there source available to examine? Or are you asking if I can compile a program against ppl with similar functionality and examine the scheduler tasks are run on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants