Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AgentOps Runtime Logging Implementation #2682

Merged
merged 100 commits into from
Jun 7, 2024

Conversation

bboynton97
Copy link
Collaborator

@bboynton97 bboynton97 commented May 14, 2024

Why are these changes needed?

This PR adds AgentOps as an optional integration with autogen

  • Extends the Runtime Logger to support additional logging calls
  • Adds a source field to a number of logging functions
  • Adds agentops_logging.py for agent observability
  • A few type issues
  • A few typos

Checks

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2024

Codecov Report

Attention: Patch coverage is 41.30435% with 27 lines in your changes missing coverage. Please review.

Project coverage is 23.41%. Comparing base (f9d3fda) to head (7ce5af0).
Report is 10 commits behind head on main.

Files Patch % Lines
autogen/logger/sqlite_logger.py 25.00% 12 Missing ⚠️
autogen/logger/file_logger.py 26.66% 11 Missing ⚠️
autogen/runtime_logging.py 71.42% 1 Missing and 1 partial ⚠️
autogen/agentchat/conversable_agent.py 66.66% 1 Missing ⚠️
autogen/oai/client.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2682       +/-   ##
===========================================
- Coverage   33.88%   23.41%   -10.48%     
===========================================
  Files          87       88        +1     
  Lines        9422     9559      +137     
  Branches     2011     2194      +183     
===========================================
- Hits         3193     2238      -955     
- Misses       5961     7081     +1120     
+ Partials      268      240       -28     
Flag Coverage Δ
unittests 23.33% <41.30%> (-10.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

autogen/logger/file_logger.py Outdated Show resolved Hide resolved
autogen/logger/file_logger.py Show resolved Hide resolved
autogen/logger/sqlite_logger.py Outdated Show resolved Hide resolved
autogen/logger/file_logger.py Outdated Show resolved Hide resolved
@Hk669
Copy link
Collaborator

Hk669 commented Jun 4, 2024

@bboynton97 kindly use the pre-commit run --all-files to avoid the code formatting failure.

@bboynton97
Copy link
Collaborator Author

everything should pass now :) @Hk669

@Hk669
Copy link
Collaborator

Hk669 commented Jun 4, 2024

everything should pass now :) @Hk669

@bboynton97 the type check is failing https://github.com/microsoft/autogen/actions/runs/9362114414/job/25770274137?pr=2682

@bboynton97
Copy link
Collaborator Author

everything should pass now :) @Hk669

@bboynton97 the type check is failing https://github.com/microsoft/autogen/actions/runs/9362114414/job/25770274137?pr=2682

i just committed the fix to that

@Hk669
Copy link
Collaborator

Hk669 commented Jun 4, 2024

i just committed the fix to that

that is for the formatting. check the https://github.com/microsoft/autogen/actions/runs/9362114414/job/25770274137?pr=2682 to understand the failure. Thanks

@Hk669
Copy link
Collaborator

Hk669 commented Jun 4, 2024

@bboynton97 Thanks for the PR. looks good to me.

@Hk669 Hk669 requested a review from sonichi June 4, 2024 07:37
@ekzhu ekzhu added this pull request to the merge queue Jun 5, 2024
@ekzhu ekzhu removed this pull request from the merge queue due to a manual request Jun 5, 2024
@areibman
Copy link
Collaborator

areibman commented Jun 6, 2024

Any other changes we should make? Or are we waiting for something else to merge first? @Hk669 @sonichi @ekzhu

@Hk669
Copy link
Collaborator

Hk669 commented Jun 7, 2024

Any other changes we should make? Or are we waiting for something else to merge first? @Hk669 @sonichi @ekzhu

let me confirm and let you know the further details. Thanks

@ekzhu ekzhu added this pull request to the merge queue Jun 7, 2024
Merged via the queue into microsoft:main with commit 85ad929 Jun 7, 2024
79 of 94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants