Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for runtime logging not supported with GPTAssistantAgent #2659

Merged
merged 3 commits into from
May 22, 2024

Conversation

pk673
Copy link
Contributor

@pk673 pk673 commented May 11, 2024

Please review @IANTHEREAL @cheng-tan @jtrugman @ekzhu

Why are these changes needed?

With this change we aim to support runtime-logging with GPTAssistantAgent

Related issue number

Closes #2498
#2644

Checks

@ekzhu ekzhu added openai-assistant Issues related to assistants from OpenAI logging related to logging issue labels May 11, 2024
@ekzhu
Copy link
Collaborator

ekzhu commented May 11, 2024

@pk673 good that you started this. Can you work together with @krishnashed on this PR? I think he can submit a PR to your branch on your repo.

Hk669

This comment was marked as outdated.

@krishnashed
Copy link
Collaborator

@Hk669 there is still some work left. I'll request for changes when needed

@Hk669
Copy link
Collaborator

Hk669 commented May 11, 2024

@Hk669 there is still some work left. I'll request for changes when needed

yeah sure. Thanks

@pk673
Copy link
Contributor Author

pk673 commented May 11, 2024

@krishnashed Could you please elaborate on the changes that are still pending?

@krishnashed
Copy link
Collaborator

@pk673 can we connect? What's your discord username?

@Hk669
Copy link
Collaborator

Hk669 commented May 11, 2024

@pk673 can we connect? What's your discord username?

@krishnashed can you add me to the discussion? Thanks

@pk673
Copy link
Contributor Author

pk673 commented May 11, 2024

@krishnashed @Hk669 My discord username is priyam_20775

@Hk669 Hk669 self-requested a review May 11, 2024 19:26
@Hk669 Hk669 dismissed their stale review May 11, 2024 19:27

more changes required.

@pk673
Copy link
Contributor Author

pk673 commented May 11, 2024

@Hk669 Can you please let me know what changes are required?

Copy link
Collaborator

@krishnashed krishnashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pk673 I tested your changes, they are good to be merged.

@ekzhu
Copy link
Collaborator

ekzhu commented May 11, 2024

Can you also add me to the discord chat?

@sonichi sonichi requested a review from cheng-tan May 14, 2024 09:41
Copy link
Collaborator

@Hk669 Hk669 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krishnashed i think this is only logging the last response of the group chat in chat completion log. is this issue solved?
@pk673 please look into the above issue

@Hk669
Copy link
Collaborator

Hk669 commented May 16, 2024

@krishnashed i think this is only logging the last response of the group chat in chat completion log. is this issue solved? @pk673 please look into the above issue

issue addressed in #2677

@ekzhu ekzhu enabled auto-merge May 21, 2024 17:16
@ekzhu ekzhu requested a review from Hk669 May 21, 2024 17:17
Copy link
Collaborator

@Hk669 Hk669 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@Hk669
Copy link
Collaborator

Hk669 commented May 21, 2024

@pk673 thanks for the contribution.

@ekzhu ekzhu added this pull request to the merge queue May 22, 2024
Merged via the queue into microsoft:main with commit 3e11b07 May 22, 2024
76 of 90 checks passed
jayralencar pushed a commit to jayralencar/autogen that referenced this pull request May 28, 2024
Co-authored-by: HRUSHIKESH DOKALA <96101829+Hk669@users.noreply.github.com>
Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logging related to logging issue openai-assistant Issues related to assistants from OpenAI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Runtime logging not supported with GPTAssistantAgent
4 participants