Password Security #716
Password Security #716
Conversation
| // We're already using mui, why are we reinventing the wheel? https://mui.com/material-ui/react-text-field/ | ||
| // if it's a matter of className control on the underlying components, that still works with the mui textfield with the InputLabelProps prop and other componentProps |
There was a problem hiding this comment.
https://mui.com/material-ui/react-text-field/
I forgot about us recreating the TextField manually
I still hate it, but this time around I'm gonna make an issue out of that and solve it myself
SteveMicroNova
requested review from
rtertiaer and
klay2000
and removed request for
rtertiaer
| key={field.name} | ||
| name={field.name} | ||
| desc={field.desc} | ||
| type="password" |
There was a problem hiding this comment.
can you just toggle this field on & off instead of duplicating this many lines of code and having a conditional return value?
Not just pandora, pandora is just the only one I know of that has a password and so I named the branch after that, it still works with all parts labeled "password" on the stream create and edit modal |
| switch (field.type) { | ||
| case "text": | ||
| let type = "text"; | ||
| if(field.name == "password"){ | ||
| type = "password"; |
There was a problem hiding this comment.
i think i'd probably prefer to change the type of the password fields, instead of behaving magically with specifically named text fields. this also creates a new component - it's perhaps somewhat more LOC, but more maintainable, and you don't have to change the interface of some underlying component.
SteveMicroNova
force-pushed
the
PandoraPasswordSecurity
branch
from
fef0f07
to
060aeba
Compare
SteveMicroNova
force-pushed
the
PandoraPasswordSecurity
branch
from
4ce433a
to
fbf38e0
Compare
Update CHANGELOG.md Streamline password redacting Add default option for StreamModal boxes Remove required tag, add default value to type on custom TextField element Explicitly handle input types
SteveMicroNova
force-pushed
the
PandoraPasswordSecurity
branch
from
fbf38e0
to
8f18f29
Compare
What does this change intend to accomplish?
Minor security improvement
The password is still plaintext in the backend, but it is now not copyable from the textbox and the textbox converts it into dots as password fields should
Checklist
./scripts/test