Code Issue in /plugins/notifications/sendgrid #7068 #7115
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@tesfamickal is attempting to deploy a commit to the medusajs Team on Vercel. A member of the Team first needs to authorize it. |
Yes I found this issue too. Took me a day to figure this out. |
shahednasser
requested changes
Jun 3, 2024
| @@ -686,7 +686,7 @@ You don’t have to create a template for every type in the reference. You can s | |||
|
|
|||
| ### Order Shipment Created | |||
|
|
|||
| **Key in plugin options:** `order_shipped_template` | |||
| **Key in plugin options:** `order_shipment_created_template` | |||
There was a problem hiding this comment.
Suggested change
| **Key in plugin options:** `order_shipment_created_template` | |
| **Key in plugin options:** `order_shipment_created_template` in the root options, and `order_shipped_template` in the localization options. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed order_shipped_template to be renamed to order_shipment_created_template