Ensure to perform complex column updates only when supported #22232
+74
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Some database engines, like TiDb, are performing sanity checks for table updates. Those might include checking if all columns used already exist. In such a case a query that adds a new column and e.g. directly uses it for an index will fail.
This PR changes how dimension updates are performed, so queries are executed separately instead of combined, if the database doesn't support it.
The same is applied for the
AddColumns
database migration class. It allows adding multiple columns, while every column will be placed after the one added before. This might also fail, so each column needs to be added separatelyReview