-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track already formatted data table columns #21444
base: 5.x-dev
Are you sure you want to change the base?
Conversation
/** | ||
* @param mixed $value | ||
*/ | ||
public function setFormattedColumn(string $name, $value): void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could perhaps return type self
and return $this
to support fluent methods chaining?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally I like the idea of method chaining. But we imho should decide to either add that to all methods in a class or to none. Everything between might confuse more than it helps in the end.
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers |
Description:
Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.
Review