refactor: use version type rather than strings #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: the `SafeReleaseRepositoryInterface` was renamed to `SafeReleaseRepoActions`. The former name was verbose and clumsy, and I had wanted to rename it for a while.
BREAKING CHANGE: the `semver::Version` type is used rather strings for working with versions. The need for the version parsing test and tests for retrieving the latest version was removed. The latter of those was only testing that returned string was a valid semantic version, which wouldn't be possible with a `Version` type.
RolandSherwin
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f2dad2d refactor: rename release interface
BREAKING CHANGE: the
SafeReleaseRepositoryInterfacewas renamed toSafeReleaseRepoActions.The former name was verbose and clumsy, and I had wanted to rename it for a while.
5ae1e06 refactor: use version type rather than strings
BREAKING CHANGE: the
semver::Versiontype is used rather strings for working with versions.The need for the version parsing test and tests for retrieving the latest version was removed. The
latter of those was only testing that returned string was a valid semantic version, which wouldn't
be possible with a
Versiontype.