refactor: use version type rather than strings #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade to `sn-releases` version 0.2.0, which forces the use of the `semver::Version` type rather than `String` for dealing with versions. It made sense to do the same thing with string-based version fields in this crate. All of the fields on the `Settings` type were also turned into an `Option`, which makes sense because it's possible that we don't have one of the asset types installed. I'm not sure why this wasn't done in the first place. It made the code a bit simpler. BREAKING CHANGE: settings files from previous versions will not deserialize properly and will have to be deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to
sn-releasesversion 0.2.0, which forces the use of thesemver::Versiontype rather thanStringfor dealing with versions.It made sense to do the same thing with string-based version fields in this crate. All of the fields on the
Settingstype were also turned into anOption, which makes sense because it's possible that we don't have one of the asset types installed. I'm not sure why this wasn't done in the first place. It made the code a bit simpler.BREAKING CHANGE: settings files from previous versions will not deserialize properly and will have to be deleted.