feat(node): notify storage payment on receival #1655
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -521,10 +567,14 @@ | |||
| .reward_wallet_balance | |||
| .set(new_balance as i64); | |||
|
|
|||
| if royalties_cash_notes_r.is_empty() { | |||
| // TODO: so far, it's assumed the store_cost and royalty are paid by single spend | |||
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| }); | ||
| let network = self.network.clone(); | ||
|
|
||
| // TODO: shall use a proper `collector`? |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
maqi
force-pushed
the
reward_notification
branch
5 times, most recently
from
ae0dca9
to
acfc7b1
Compare
maqi
changed the title
maqi
force-pushed
the
reward_notification
branch
4 times, most recently
from
b66f06a
to
81483c4
Compare
|
Closed as not required to achieve real time network wide statistic monitor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
reviewpad:summary