feed foundation wallet by default, not faucet #1636
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -591,15 +591,31 @@ | |||
| } | |||
|
|
|||
| /// Loads a serialized wallet from a path. | |||
| // TODO: what's the behaviour here if path has stored key and we pass one in? | |||
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
joshuef
force-pushed
the
FoundationWalletDefault
branch
2 times, most recently
from
7b3dd64
to
45ce59d
Compare
joshuef
force-pushed
the
FoundationWalletDefault
branch
12 times, most recently
from
45718ca
to
c4dd2ba
Compare
Allows for reuse in faucet works and proper ci usage. Makes the account packet tooling more client layer there.
Use account packet helpers to generate wallet reliably now errors out if no wallet is found
So we no longer gift the entire genesis amount to the faucet (which we can fund in other means). but we retain a feat for this for testing etc
joshuef
force-pushed
the
FoundationWalletDefault
branch
from
c4dd2ba
to
1a3aab9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
reviewpad:summary