feat(networking): adding API to perform sybil attack check #1573
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bochaco
force-pushed
the
feat-sybil-detection
branch
from
037b455
to
01684e6
Compare
bochaco
force-pushed
the
feat-sybil-detection
branch
from
01684e6
to
7ae76ec
Compare
bochaco
force-pushed
the
feat-sybil-detection
branch
from
7ae76ec
to
0522e65
Compare
bochaco
force-pushed
the
feat-sybil-detection
branch
from
cdd9b5e
to
f01b7cc
Compare
| @@ -431,6 +435,8 @@ | |||
| } | |||
| } | |||
| SwarmCmd::PutLocalRecord { record } => { | |||
| // TODO: eclipse content if sybil was set, if sybil xorname set is close to the key ....? | |||
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| @@ -379,6 +381,8 @@ | |||
| sender, | |||
| quorum, | |||
| } => { | |||
| // TODO: eclipse content if sybil was set, if sybil xorname set is close to the key ....? | |||
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| @@ -364,6 +364,8 @@ | |||
| .payment_received(); | |||
| } | |||
| SwarmCmd::GetLocalRecord { key, sender } => { | |||
| // TODO: eclipse content if sybil was set, if sybil xorname set is close to the key ....? | |||
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
bochaco
force-pushed
the
feat-sybil-detection
branch
2 times, most recently
from
1d313c5
to
38e406b
Compare
bochaco
force-pushed
the
feat-sybil-detection
branch
from
a2578fe
to
743d670
Compare
bochaco
force-pushed
the
feat-sybil-detection
branch
2 times, most recently
from
48b20ff
to
86ca0e2
Compare
bochaco
force-pushed
the
feat-sybil-detection
branch
from
86ca0e2
to
cf6dbb6
Compare
bochaco
force-pushed
the
feat-sybil-detection
branch
2 times, most recently
from
866df65
to
50cfb4a
Compare
| let k = peers.len(); | ||
| info!(">>> CHECKING SYBIL ATTACK WITH {k} PEERS: {peers:?}"); | ||
|
|
||
| // FIXME: return error if we don't have at least K peer ids per key |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
|
|
||
| // Threshold to determine if there is an attack using Kullback-Liebler (KL) divergence | ||
| // between model peer ids distribution vs. actual distribution around any point in the address space. | ||
| const KL_DIVERGENCE_THRESHOLD: f64 = 10f64; // TODO: find a proper value |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
bochaco
force-pushed
the
feat-sybil-detection
branch
3 times, most recently
from
d7ce052
to
72f85ed
Compare
bochaco
force-pushed
the
feat-sybil-detection
branch
from
72f85ed
to
83f47bf
Compare
| fn get_net_size_estimate(random_keys: &RandomKeysAndClosestPeerIds) -> usize { | ||
| let mut best_n_found = 0; | ||
| let mut smallest_value_found = f64::MAX; | ||
| // FIXME: this iteration needs to be smarter |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
bochaco
force-pushed
the
feat-sybil-detection
branch
from
83f47bf
to
992fcee
Compare
Description
reviewpad:summary