Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized margin for mobile devices #4727

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tshipenchko
Copy link

@tshipenchko tshipenchko commented Apr 30, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

This PR changes distribution of margin in status page.

On mobile devices the buttons stick to each other. Giving 50% of margin to elements from the div will fix the issue

Type of change

  • User interface (UI)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots

Before After
image image

@CommanderStorm
Copy link
Collaborator

The two buttons being stacked on that side seems a bit off center to me.
I think if we remove the icons on mobile this might be a better call. What do you think?

image

@tshipenchko
Copy link
Author

I will partly solve the problem, but it still be present on some devices. Also it will break style of the page.

@CommanderStorm
Copy link
Collaborator

Also it will break style of the page

Could you explain further?

Another option would be to shorten the text from Edit Status Page to Edit.

@tshipenchko
Copy link
Author

tshipenchko commented Apr 30, 2024

Could you explain further?

Uptime Kuma uses a lot of icons in its user interface. While there are no longer any icons on status pages, I think in general it will look out of place.

Shorten the text is a good option

@CommanderStorm CommanderStorm added the needs:work this PR needs work label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:work this PR needs work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants