New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add background color change on hover to nav links #4494
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not really look like the other button-hover effects we already have.
I see why you thought that this would be the correct approach. The item
-hoverable things, such as single status pages, behave this way.
I think currently these are buttons (maybe they should not? => unclear)
=> making this primary on hover not truly fit into the current design language as far as I see. (open to discussion)
I would expect this to be a light-gray in the light mode and a dark gray in the dark mode, as the other buttons "lighten" on hover.
This comment was marked as outdated.
This comment was marked as outdated.
3a4631b
to
94154c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this PR and the current way this is implemented is not mergable. I have updated the screenshots in the description.
Again, my communication was not clear in the review. Need to work on that ^^
In the dark mode the currently selected button is now just black on dark gray if hovered over, and in the light mode it does not have any visual effect I can perceive.
I would expect this to behave like our other buttons…
The hover effect for non-selected looks nice though 👍🏻
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Fixes #1753
Type of change
Please delete any options that are not relevant.
Checklist
Screenshots (if any)