Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Testing monitors with Testcontainers #4451

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

CommanderStorm
Copy link
Collaborator

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

This issue is meant as a discussion.

I have thought a bunch about how our monitors can be tested and have come to the conclusion that for most monitors, testcontainers seem like a good fit.
Testing this part would allow us to merged PRs like #4445 or #4393 without the risk or the level of manual verification required.

Things that we should discuss:

  • should new monitors be tested like this
  • does addition of these tests add additional value? How important/is this important? (=> "do we want this? if yes, which merge slot")

Type of change

Please delete any options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Other
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

<- screenshot of testcases passing ->

@Zaid-maker

This comment was marked as off-topic.

@louislam
Copy link
Owner

louislam commented Feb 4, 2024

Interesting. It is able to run on GitHub Actions?

@Zaid-maker
Copy link
Contributor

Interesting. It is able to run on GitHub Actions?

Yes I guess so I tried it once

@CommanderStorm
Copy link
Collaborator Author

I don't see a reason why it cannot.
There might be some (minor) CI adaptations, but I can make + test those.

@chakflying chakflying changed the title Testing of monitors Unit Testing monitors with Testcontainers Mar 2, 2024
@CommanderStorm CommanderStorm added the needs:work this PR needs work label May 19, 2024
@github-actions github-actions bot added needs:resolve-merge-conflict A merge-conflict needs to be addressed before reviewing makes sense again and removed needs:resolve-merge-conflict A merge-conflict needs to be addressed before reviewing makes sense again labels May 19, 2024
@github-actions github-actions bot added needs:resolve-merge-conflict A merge-conflict needs to be addressed before reviewing makes sense again and removed needs:resolve-merge-conflict A merge-conflict needs to be addressed before reviewing makes sense again labels May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:monitor Everything related to monitors needs:resolve-merge-conflict A merge-conflict needs to be addressed before reviewing makes sense again needs:work this PR needs work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants